fix: add type ignore to fix lint

microsoft · Feb 26, 2025 · 78e1c9f · 78e1c9f
1 parent 78a7038
commit 78e1c9f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 10 deletions.
diff --git a/python/packages/ai/teams/ai/ai.py b/python/packages/ai/teams/ai/ai.py
@@ -314,7 +314,7 @@ async def _on_say_command(
         content_text = content if not citations else format_citations_response(content)
 
         # If there are citations, filter out the citations unused in content.
-        referenced_citations = get_used_citations(content_text, citations)
+        referenced_citations = get_used_citations(content_text, citations) # type: ignore
         channel_data: Dict[str, Any] = {}
 
         if is_teams_channel:
@@ -331,7 +331,9 @@ async def _on_say_command(
                 channel_data=channel_data,
                 entities=[
                     AIEntity(
-                        citation=(list(referenced_citations) if referenced_citations else []),
+                        citation=(
+                            list(referenced_citations) if referenced_citations else []# type: ignore
+                        ),
                         additional_type=["AIGeneratedContent"],
                     ),
                 ],

diff --git a/python/packages/ai/teams/streaming/streaming_response.py b/python/packages/ai/teams/streaming/streaming_response.py
@@ -292,11 +292,11 @@ async def send_activity(self, activity: Activity) -> None:
 
         # If there are citations, filter out the citations unused in content.
         if self._citations and len(self._citations) > 0 and self._ended is False:
-            curr_citations = get_used_citations(self._message, self._citations)
+            curr_citations = get_used_citations(self._message, self._citations) # type: ignore
             activity.entities.append(
                 AIEntity(
                     additional_type=[],
-                    citation=curr_citations if curr_citations else [],
+                    citation=curr_citations if curr_citations else [], # type: ignore
                 )
             )
 

diff --git a/python/packages/ai/teams/utils/citations/get_used_citations.py b/python/packages/ai/teams/utils/citations/get_used_citations.py
@@ -29,7 +29,7 @@ def get_used_citations(
     if not matches:
         return None
 
-    used_citations = []
+    used_citations: List[Union[ClientCitation, Dict[str, Any]]] = []  # Explicitly type this
     processed_matches = []
     for match in matches:
         if match in processed_matches:

diff --git a/python/packages/ai/tests/utils/citations/test_get_used_citations.py b/python/packages/ai/tests/utils/citations/test_get_used_citations.py
@@ -22,7 +22,7 @@ def test_get_used_citations(self):
             ),
         ]
         text = "hello [1] world"
-        result = get_used_citations(text, citations)
+        result = get_used_citations(text, citations) # type: ignore
         assert result is not None
         self.assertEqual(len(result), 1)
 
@@ -48,7 +48,7 @@ def test_get_used_citations_longer(self):
             ),
         ]
         text = "hello [1] world [3]"
-        result = get_used_citations(text, citations)
+        result = get_used_citations(text, citations) # type: ignore
         if result is not None:
             self.assertEqual(len(result), 2)
         else:
@@ -81,20 +81,20 @@ def test_get_used_citations_dict(self):
         ]
 
         text = "hello [2] world [3]"
-        result = get_used_citations(text, citations)
+        result = get_used_citations(text, citations) # type: ignore
 
         assert result is not None
         self.assertEqual(len(result), 2)
         self.assertEqual(result, [citations[1], citations[2]])
 
         # Test with empty matches
         text_no_citations = "hello world with no citations"
-        result_empty = get_used_citations(text_no_citations, citations)
+        result_empty = get_used_citations(text_no_citations, citations) # type: ignore
         self.assertIsNone(result_empty)
 
         # Test with duplicate citations
         text_duplicate = "hello [1] world [1] again"
-        result_duplicate = get_used_citations(text_duplicate, citations)
+        result_duplicate = get_used_citations(text_duplicate, citations) # type: ignore
         assert result_duplicate is not None
         self.assertEqual(len(result_duplicate), 1)
         self.assertEqual(result_duplicate, [citations[0]])