Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Support SSO for Message Extension Link Unfurling feature #1054

Open
Tracked by #1102
blackchoey opened this issue Dec 12, 2023 · 0 comments
Open
Tracked by #1102

[Feature Request]: Support SSO for Message Extension Link Unfurling feature #1054

blackchoey opened this issue Dec 12, 2023 · 0 comments
Labels
dotnet Change/fix applies to dotnet. If all three, use the 'JS & dotnet & Python' label enhancement New feature or request fc-enhancements JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label Python Change/fix applies to Python. If all three, use the 'JS & dotnet & Python' label

Comments

@blackchoey
Copy link
Contributor

Describe your user scenario

Message Extension Link Unfurling also supports SSO. Currently the library will only use auth (not silentAuth) when received a link unfurling request, so developers cannot leverage SSO in this case.

Describe the solution you'd like

The library should send silentAuth response if developers want to enable SSO.

Additional context

Currently there seems to be a bug in Message Extension Link Unfurling's SSO support: it cannot render login card if token exchange failed (bot returns 412). There is a workaround but we may also report to related team and ask for suggestions.
@blackchoey blackchoey added enhancement New feature or request dotnet Change/fix applies to dotnet. If all three, use the 'JS & dotnet & Python' label JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label labels Dec 12, 2023
@corinagum corinagum mentioned this issue Jun 13, 2024
Open
@corinagum corinagum added fc-enhancements Python Change/fix applies to Python. If all three, use the 'JS & dotnet & Python' label labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dotnet Change/fix applies to dotnet. If all three, use the 'JS & dotnet & Python' label enhancement New feature or request fc-enhancements JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label Python Change/fix applies to Python. If all three, use the 'JS & dotnet & Python' label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corinagum @blackchoey