Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] docs: Created C# README equivalent to JS README file #1057 #1103

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

Carter425
Copy link
Contributor

#minor
Creating a C# README doc equivalent to the JS README doc, but with updated C# links and language. IMPORTANT - The example/basic code under Migration section and under AI Prompt manager still needs to be changed to C# from JS. I would need Kavin or Alex to ensure this is done correctly. Alternatively, I can take this code out and just have people refer to the Migration Guide and AI Setup Guide links.

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (we use TypeDoc to document our code)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Additional information

Feel free to add other relevant information below

@Carter425
Copy link
Contributor Author

Hi @corinagum, @singhk97, and @aacebo,

I made the equivalent README file for C# as JS has. The wording and links are updated. Importantly, as I noted above, the basic code for Migration and Prompt Manager are still in JS. I would need help here or I can just refer to the C# migration and AI Setup Guides.

Copy link
Collaborator

@aacebo aacebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about C# readme contents

@aacebo aacebo self-requested a review January 2, 2024 17:37
@aacebo aacebo merged commit 6f744df into main Jan 3, 2024
7 checks passed
@aacebo aacebo deleted the rcg/docs branch January 3, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants