Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] feat: add unit tests for Teams SSO auth related classes #1112

Merged
merged 7 commits into from
Jan 4, 2024

Conversation

blackchoey
Copy link
Contributor

@blackchoey blackchoey commented Jan 3, 2024

Linked issues

closes: #1053 #1110

Details

  1. Create an adapter for MSAL library to make the classes testable with mock
  2. Update existing class implementation to use the MSAL library adapter
  3. Do not check token cache in TeamsSsoPrompt because the Authentication handler already checks token cache before invoking the prompt
  4. Add unit tests

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (we use TypeDoc to document our code)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

@blackchoey blackchoey changed the title [C#] test: add unit tests for Teams SSO auth related classes [C#] feat: add unit tests for Teams SSO auth related classes Jan 3, 2024
@blackchoey blackchoey marked this pull request as ready for review January 3, 2024 08:58
@corinagum corinagum merged commit be8825a into main Jan 4, 2024
10 checks passed
@corinagum corinagum deleted the chyuan/csharp-ut branch January 4, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#] Teams SSO auth unit tests
3 participants