Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] fix: update streamType enum conversion to string #2178

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

lilyydu
Copy link
Collaborator

@lilyydu lilyydu commented Nov 11, 2024

Linked issues

closes: #minor

Details

for entities object, update streamType enum conversion to string instead of int

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

@lilyydu lilyydu merged commit 804ff05 into dotnet-dev Nov 11, 2024
9 checks passed
@lilyydu lilyydu deleted the lilyydu/streamType-dotnet branch November 11, 2024 22:29
@singhk97 singhk97 mentioned this pull request Nov 12, 2024
1 task
singhk97 added a commit that referenced this pull request Nov 12, 2024
## Linked issues

closes: #minor

## Details
Introduce fix:
* #2178

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Lily Du <[email protected]>
Co-authored-by: lilydu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants