Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] fix: Typing indicator is "stuck" #2250

Merged
merged 1 commit into from
Jan 6, 2025
Merged

[C#] fix: Typing indicator is "stuck" #2250

merged 1 commit into from
Jan 6, 2025

Conversation

singhk97
Copy link
Collaborator

Linked issues

closes: #minor

Details

Fixes the issue where the typing timer is stuck after the bot sends the message.

Change details

  • The send "typing" activity method is awaited to complete before the send "message" activity is processed.

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

@singhk97 singhk97 changed the base branch from main to dotnet-dev December 30, 2024 23:53
@singhk97 singhk97 changed the title [C#] fix: Typing timer being "stuck" fix [C#] fix: Typing indicator is "stuck" Dec 30, 2024
@singhk97 singhk97 merged commit 87232fa into dotnet-dev Jan 6, 2025
13 checks passed
@singhk97 singhk97 deleted the kavin/tt-fix branch January 6, 2025 17:38
@singhk97 singhk97 mentioned this pull request Feb 4, 2025
1 task
singhk97 added a commit that referenced this pull request Feb 4, 2025
## Linked issues

closes: #minor

## Details
- Bump `Microsoft.Teams.AI` to version 1.10.0
- Update samples to point to this version.

**New Changes**
#2235
#2250
#2278
#2232

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Lily Du <[email protected]>
Co-authored-by: lilydu <[email protected]>
Co-authored-by: Tarek Mahmoud Sayed <[email protected]>
Co-authored-by: Steven Ickman <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Corina <[email protected]>
Co-authored-by: Yiqing Zhao <[email protected]>
Co-authored-by: Yiqing Zhao <[email protected]>
Co-authored-by: Alex Acebo <[email protected]>
Co-authored-by: Eric Zhu <[email protected]>
Co-authored-by: Peter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants