Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] chore: Add clarity to chef bot README's #2300

Merged
merged 2 commits into from
Feb 7, 2025
Merged

[JS] chore: Add clarity to chef bot README's #2300

merged 2 commits into from
Feb 7, 2025

Conversation

corinagum
Copy link
Collaborator

Linked issues

closes: #2299

Details

  • Minor cleanup of streaming index.ts
  • Changed likely embedding deployment name in VectraDataSource
  • Add note to change embeddings settings in VectraDataSource in the README.md
  • Other minor cleanup of README.md

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

@corinagum corinagum merged commit aa93322 into main Feb 7, 2025
10 checks passed
@corinagum corinagum deleted the cg/i branch February 7, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sample] Improve streaming sample with feedback
2 participants