From d7d89ef35471f8ddc7774d755f7bfbfa71b84fb5 Mon Sep 17 00:00:00 2001 From: Mike Griese Date: Fri, 7 Jan 2022 13:56:26 -0600 Subject: [PATCH] Fix scheme previewing on Appearances page of SUI (#12095) This PR makes sure profile appearances in SUI set both focused and unfocused members of the control. I totally forgot about the fact that the control is _unfocused_ in the SUI. Verified manually, I didn't think it deserved a gif. * regressed in #11619 * Closes #11893 * I work here --- src/cascadia/TerminalSettingsEditor/Profiles.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cascadia/TerminalSettingsEditor/Profiles.cpp b/src/cascadia/TerminalSettingsEditor/Profiles.cpp index 39f7916d061..1b54ecb2b62 100644 --- a/src/cascadia/TerminalSettingsEditor/Profiles.cpp +++ b/src/cascadia/TerminalSettingsEditor/Profiles.cpp @@ -74,13 +74,13 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation { _PropertyChangedHandlers(*this, PropertyChangedEventArgs{ L"CurrentScrollState" }); } - _previewControl.UpdateControlSettings(_Profile.TermSettings()); + _previewControl.UpdateControlSettings(_Profile.TermSettings(), _Profile.TermSettings()); }); // The Appearances object handles updating the values in the settings UI, but // we still need to listen to the changes here just to update the preview control _AppearanceViewModelChangedRevoker = _Profile.DefaultAppearance().PropertyChanged(winrt::auto_revoke, [=](auto&&, const PropertyChangedEventArgs& /*args*/) { - _previewControl.UpdateControlSettings(_Profile.TermSettings()); + _previewControl.UpdateControlSettings(_Profile.TermSettings(), _Profile.TermSettings()); }); // Navigate to the pivot in the provided navigation state @@ -90,7 +90,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation // so wait for it to initialize before updating the settings (so we know // that the renderer is set up) _previewControl.Initialized([&](auto&& /*s*/, auto&& /*e*/) { - _previewControl.UpdateControlSettings(_Profile.TermSettings()); + _previewControl.UpdateControlSettings(_Profile.TermSettings(), _Profile.TermSettings()); }); }