Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colored Italic letter rendering issue #10503

Closed
chrisdcao opened this issue Jun 23, 2021 · 4 comments
Closed

Colored Italic letter rendering issue #10503

chrisdcao opened this issue Jun 23, 2021 · 4 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@chrisdcao
Copy link

chrisdcao commented Jun 23, 2021 •
edited
Loading

Windows Terminal version (or Windows build number)

10.0.19042.1052

Other Software

Ubuntu WSL, using Vim inside the terminal

Steps to reproduce

Use either Fira Code, Monaco, or Ubuntu Mono at any size, and use a theme that has italic highlight in type (monokai.vim with italic turned on or dark_plus.vim) will successfully render the issue.

But the issue does not occur in italicized comment..

Expected Behavior

The letter 'd' will not be cut off part of it (like in the comment)

Actual Behavior

The letter 'd' being cut off part of it (the highlighted type above)
Screenshot_31
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 23, 2021
@chrisdcao
Copy link
Author

The smaller the font, the worse the problem, but the issue's not happening in the comment area. My guess is the bright colors are being rendered differently to fit the pixel grid?

Screenshot_32

@norcalli
Copy link

The color transition between words is probably the culprit, being a different scissor area, would be my guess. The comment is all the same color.

@j4james
Copy link
Collaborator

j4james commented Jun 24, 2021

See also #9381, which is essentially the same issue.

@chrisdcao
Copy link
Author

yea I would close this one then! Any track would be moved to #9381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@norcalli @j4james @chrisdcao