Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"One Half Light" theme vim visual line can't be seen as it blends with the background. #10782

Closed
0xtimsb opened this issue Jul 24, 2021 · 2 comments
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered

Comments

@0xtimsb
Copy link

0xtimsb commented Jul 24, 2021

Windows Terminal version (or Windows build number)

1.9.1942.0

Other Software

vim in WSL 2

Steps to reproduce

Use shift + v to go in visual line mode in vim. Set "one half light" as your theme. The visual line can't be seen.

image

Expected Behavior

It should have greyish color, like it is in tango theme.

Actual Behavior

Visual line color bends in with the background.blends

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 24, 2021
@j4james
Copy link
Collaborator

j4james commented Jul 24, 2021

If you're using a light theme like "One Half Light", I believe you need to set the vim color scheme to match. For example, try using :colorscheme peachpuff in vim. That should make the visual line visible.

That said, I think vim might be able to do this automatically if it detects the terminal is using a light theme, but it probably relies on color querying sequences which we don't yet support (see #3718).

@zadjii-msft
Copy link
Member

Yea, this just sounds like you need to configure vim theme to work with your color scheme. Every scheme's got it's own quirks. There's quite a few combos of colors in One Half Light that aren't all that readable:

image

@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered labels Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

3 participants