Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Defining a default color scheme for all terminals #10840

Closed
torgeros opened this issue Aug 1, 2021 · 7 comments
Closed

FR: Defining a default color scheme for all terminals #10840

torgeros opened this issue Aug 1, 2021 · 7 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Issue-Question For questions or discussion Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered

Comments

@torgeros
Copy link

torgeros commented Aug 1, 2021

Description of the new feature/enhancement

Allow the user to set the color scheme for all (or some) profiles.

I personally use the new terminal (only) for working with the WSL. I have different profiles that load different .bashrc-files according to what I am planning to work with.

I would like to be able to set the color schemes of those in one quick action. That is especially important as I switch between light and dark themes for my OS very often, sometimes even time-of-day-depoendent. Having to switch the color schemes for each profile individually is very annoying.

Proposed technical implementation details (optional)

  1. A dropdown menu to set the default color scheme to one of the defined schemes
  2. For each profile: an option in the dropdown that selects the theme that points to "Default scheme"

An even better solution could be to be able to set a default light-mode theme and a default dark-mode theme. That would change the colors of a console tab from light to dark when toggling light/dark mode in WIndows System Settings.

@torgeros torgeros added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 1, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 1, 2021
@j4james
Copy link
Collaborator

j4james commented Aug 2, 2021

An even better solution could be to be able to set a default light-mode theme and a default dark-mode theme.

There's already an issue open for that feature. See #4066.

@torgeros
Copy link
Author

torgeros commented Aug 2, 2021

There's already an issue open for that feature. See #4066.

Okay but then in addition to that, the main point of this issue should be to be able to set a default theme that applies to all profiles

@zadjii-msft
Copy link
Member

You could always try setting the colorScheme in profiles.defaults.

"profiles": {
  "defaults": {
    "colorScheme": "Campbell"
  }
  "list": [...]
}

You can also quickly switch schemes with the Command palette and the "select color scheme..." action

@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered labels Aug 2, 2021
@torgeros
Copy link
Author

torgeros commented Aug 2, 2021

You could always try setting the colorScheme in profiles.defaults.

"profiles": {
  "defaults": {
    "colorScheme": "Campbell"
  }
  "list": [...]
}

You can also quickly switch schemes with the Command palette and the "select color scheme..." action

That is good to know, but the existing "default-scheme" is only used when creating a new profile, isn't it? The problem that I cant change the color theme for multiple open tabs with different profiles remains.

@zadjii-msft
Copy link
Member

is only used when creating a new profile, isn't it?

Nope, it's used whenever a profile doesn't have another scheme set. So in this example:

"profiles": {
  "defaults": {
    "colorScheme": "Campbell"
  },
  "list": [
    {
      "name": "foo",
      "colorScheme": "Solarized"
    },
    {
      "name": "bar"
    }
  ]
}

foo's color scheme would be "Solarized", but bar's would fall back to "Campbell". Change "Campbell" to "Monokai" in the profiles.defaults section, and now bar's scheme would automatically change to "Monokai"

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 2, 2021
@torgeros
Copy link
Author

torgeros commented Aug 3, 2021

Thank you, that is good to know!

If I understand correctly, there are two things missing to create the wanted behaviour:

First one is an option to unset the used theme from the GUI-settings, which could be done by inserting an option "default" to the theme-dropdown and making it remove the line "colorScheme": "..." from the JSON file when it is selected.

Second one is an option under "Appearance" that select a default color scheme as that is currently only possible through JSON.
After this has been implemented it could be used to make fixing #4066 a little easier..

That sounds sufficiently easy to fix, if I find time to do it, I will fix it myself.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 3, 2021
@zadjii-msft
Copy link
Member

@torgeros You actually don't need to worry about that! We're already working on bringing the "Defaults" back to the SUI. That'll have a separate page for the defaults, and little buttons to revert individual profile settings back to the value in the defaults:

image
image

IIRC that's in 1.10 Preview (#10588)

@microsoft microsoft locked and limited conversation to collaborators Jan 7, 2022
@DHowett DHowett converted this issue into discussion #12108 Jan 7, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Issue-Question For questions or discussion Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

3 participants