Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quake mode does not consider vertical taskbar width #10999

Open
Tracked by #8888
Lyrex opened this issue Aug 21, 2021 · 1 comment
Open
Tracked by #8888

Quake mode does not consider vertical taskbar width #10999

Lyrex opened this issue Aug 21, 2021 · 1 comment
Labels
Area-Windowing Window frame, quake mode, tearout Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@Lyrex
Copy link

Lyrex commented Aug 21, 2021

Windows Terminal version (or Windows build number)

10.0.19042.1165, 1.9.1942.0

Other Software

No response

Steps to reproduce

  1. Make sure you have at least one monitor with a vertical task bar.
  2. Open a Quake mode window on the monitor with the vertical task bar.

Expected Behavior

The Quake mode window should not be partially hidden behind the vertical task bar. It should recognize a vertical task bar is used and resize and reposition accordingly.

Actual Behavior

One side of the terminal looks cut off by the sidebar and it seeems to be positioned behind the task bar.

screenshot of the current behavior
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 21, 2021
@zadjii-msft
Copy link
Member

Good catch! I guess I assumed that the rectangle I was using was the work rect, not the monitor one.

@zadjii-msft zadjii-msft added Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Aug 23, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Aug 23, 2021
@zadjii-msft zadjii-msft mentioned this issue Aug 23, 2021
Open
61 tasks
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Aug 23, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 27, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Windowing Window frame, quake mode, tearout Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@DHowett @Lyrex @zadjii-msft