Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some ligature rendered abnormally #12601

Closed
zhang-stephen opened this issue Mar 1, 2022 · 11 comments
Closed

some ligature rendered abnormally #12601

zhang-stephen opened this issue Mar 1, 2022 · 11 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@zhang-stephen
Copy link

zhang-stephen commented Mar 1, 2022

Windows Terminal version

1.13.10395.0(preview)

Windows build number

10.0.19042.1466

Other Software

Something over SSH to CentOS 7.9:

  • neovim 0.6.1
  • tmux 3.1a

Fonts:
FiraCode NF(with windows compatible)

Steps to reproduce

  1. install FiraCode NF follow above link

  2. terminal configuration:

    {
        "protiles": {
             "lists": [
                {
                    "adjustIndistinguishableColors": true,
                    "antialiasingMode": "cleartype",
                    "backgroundImage": null,
                    "closeOnExit": "always",
                    "colorScheme": "Campbell",
                    "commandline": "ssh <username>@<hostname>",
                    "name": "<remoteHost>",
                    "cursorShape": "underscore",
                    "experimental.useAtlasEngine": true,
                    "font": {
                        "face": "FiraCode NF",
                        "size": 11
                    },
                    "guid": "{6c5275a4-b63e-46ce-a2eb-e3ea1f73666f}",
                    "hidden": false,
                    "historySize": 100001,
                    "opacity": 85,
                    "padding": "8",
                    "useAcrylic": true
                }
            ]
        }
    }
  3. print this text on terminal(the logo of neovim in following screenshots):
    test.txt

  4. it could be reproduced under powershell 7 on Windows

Expected Behavior

the true rendering in other terminal:

image
image

Actual Behavior

you can find ligatures not effective in screenshots:

image
image

screenshot of Powershell 7:
image

@zhang-stephen zhang-stephen added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Mar 1, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 1, 2022
@Finii
Copy link

Finii commented Mar 1, 2022

I believe this is no bug of Windows Terminal but is related to the used font. The linked font is a rather old variant and there have been several fixes in the glyph sizes in the meanwhile. Will check with a HEAD release of that font.

@Finii
Copy link

Finii commented Mar 1, 2022

With the HEAD font I can not reproduce the issue (no breaks in horizontal box lines).
https://github.com/ryanoasis/nerd-fonts/blob/master/patched-fonts/FiraCode/Regular/complete/Fira%20Code%20Regular%20Nerd%20Font%20Complete%20Windows%20Compatible.ttf

But then I have not the Powershell window?
Maybe you can give us the NeoVim Ascii Art for a test.

image

@zadjii-msft
Copy link
Member

This might just be the same thing as #12566. Switch to grayscale antialiasing.

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 1, 2022
@zadjii-msft
Copy link
Member

Okay, sorry for the brief reply earlier. Looking more carefully, I'm gonna say this is definitely a /dup of #8993. This isn't an issue with ligatures, but rather the way cleartype antialiasing interacts with box drawing characters.

@ghost
Copy link

ghost commented Mar 1, 2022

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 1, 2022
@zhang-stephen
Copy link
Author

zhang-stephen commented Mar 1, 2022

With the HEAD font I can not reproduce the issue (no breaks in horizontal box lines). https://github.com/ryanoasis/nerd-fonts/blob/master/patched-fonts/FiraCode/Regular/complete/Fira%20Code%20Regular%20Nerd%20Font%20Complete%20Windows%20Compatible.ttf

But then I have not the Powershell window? Maybe you can give us the NeoVim Ascii Art for a test.

image

I uploaded the test.txt, includes NeoVim Ascii Art, you can find it in the first issue message. And I will try the HEAD font. thanks.

On the other hand, did you test this issue on stable release? I noticed the page settings is different to preview release.

@zhang-stephen
Copy link
Author

Okay, sorry for the brief reply earlier. Looking more carefully, I'm gonna say this is definitely a /dup of #8993. This isn't an issue with ligatures, but rather the way cleartype antialiasing interacts with box drawing characters.

I cannot find effective solution in #8993, any suggestions? I came back to the stable release in MS store right now.

@zadjii-msft
Copy link
Member

Set "antialiasingMode": "grayscale", in your profile. See #8993 (comment)

@zhang-stephen
Copy link
Author

Set "antialiasingMode": "grayscale", in your profile. See #8993 (comment)

image

thanks for your reply but it is not effective.

@zadjii-msft
Copy link
Member

Could you share your settings.json file?

@zhang-stephen
Copy link
Author

zhang-stephen commented Mar 1, 2022

settings.zip
Github doesn't support to upload .json file.

I think I found the root cause: "experimental.useAtlasEngine": true, . the rendering looks normal after this field disabled and re-opening the terminal, even "antialiasingMode" filled as cleartype, but I don't remember I have turned on it.

Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants