Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using 'left' in shortcuts produces an unreadable settings file #1324

Closed
mikemaccana opened this issue Jun 19, 2019 · 6 comments
Closed

Using 'left' in shortcuts produces an unreadable settings file #1324

mikemaccana opened this issue Jun 19, 2019 · 6 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone

Comments

@mikemaccana
Copy link
Contributor

Using SVN master as of today, modifying the inbuilt shortcuts to use left or right produces a syntax error:

            {
                "command" : "prevTab",
                "keys" : 
                [
                    "ctrl+shift+left"
                ]
            },

image

As the other arrow keys are referred to as up and down I presume left and right should work too.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 19, 2019
@DHowett-MSFT
Copy link
Contributor

Alas! We might have missed that when we switched from git to subversion. I'll tag this one for 0.3 😉

@DHowett-MSFT
Copy link
Contributor

Related: #1212

@mikemaccana
Copy link
Contributor Author

Thanks Dustin!

@zadjii-msft
Copy link
Member

@mikemaccana I'm gonna psychic debug and guess that you're trying to add the left keybinding while the terminal is open, right?

Something seems to have regressed hot-reloading the settings file, really badly in the last couple days. We're investigating in #1325

@mikemaccana
Copy link
Contributor Author

@zadjii-msft Please stop reading my mind, I have a lot of private thoughts I'd like to keep that way. 😁 Yep that's correct, terminal open.

@zadjii-msft
Copy link
Member

Yep, that's the one. I'll close this as #1325 is the real problem here

@zadjii-msft zadjii-msft added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants