Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wt.exe split-pane doesn't work in quake mode #13466

Open
CherryWorm opened this issue Jul 8, 2022 · 5 comments
Open

wt.exe split-pane doesn't work in quake mode #13466

CherryWorm opened this issue Jul 8, 2022 · 5 comments
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone

Comments

@CherryWorm
Copy link

Windows Terminal version

1.15.1863.0

Windows build number

10.0.22000.739

Other Software

No response

Steps to reproduce

Open a quake terminal and execute wt.exe -w 0 split-pane

Expected Behavior

The quake terminal to split

Actual Behavior

If a non-quake terminal is already open it is split. Otherwise a new non-quake terminal is opened and immediately split

@CherryWorm CherryWorm added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 8, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 8, 2022
@DHowett
Copy link
Member

DHowett commented Jul 8, 2022

So, because the quake window is "special" (it can be hidden in a way that normal windows can't), it's excluded from the list of recent windows that -w 0 consults.

To split the quake window, you may want to target it specifically: -w _quake will do it.

@CherryWorm
Copy link
Author

Is there any way to detect whether you're in a quake window programatically?

@DHowett
Copy link
Member

DHowett commented Jul 8, 2022

... frick. No. Excellent question.

@zadjii-msft
Copy link
Member

Huh. Yea maybe that was an oversight when doing #9956. Maybe -w 0 should still work for quake, but "Attach to the most recently used window" should not. Not sure if there's a good way to differentiate between the two, however.

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Area-Windowing Window frame, quake mode, tearout labels Jul 11, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 11, 2022
@zadjii-msft zadjii-msft added Needs-Tag-Fix Doesn't match tag requirements Needs-Discussion Something that requires a team discussion before we can proceed labels Jul 11, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 11, 2022
@zadjii-msft zadjii-msft removed the Needs-Discussion Something that requires a team discussion before we can proceed label Jul 11, 2022
@zadjii-msft
Copy link
Member

discussion: Yep, we should totally pull these two code paths apart.

@zadjii-msft zadjii-msft added this to the Backlog milestone Jul 11, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 11, 2022
@zadjii-msft zadjii-msft marked this as a duplicate and then as not a duplicate of #18459 Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants