Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using padding, starting selection from empty area continues previous selection #1367

Closed
mcpiroman opened this issue Jun 21, 2019 · 3 comments
Assignees
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone

Comments

@mcpiroman
Copy link
Contributor

Environment

commit 0846464

Steps to reproduce

  1. Set some left padding eg. 20.
  2. Make some selection or just click one cell.
  3. In some other place try to make new selection that starts at first char in line. But don't point cursor directly on the first char, but instead little to the left, on the "padded" area.

Expected behavior

Selection should start at first character in line.

Actual behavior

Previous selection is continued.
This is also the case for other padding sites (e.g. selecting line form right to left), but left is most noticable.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 21, 2019
@mcpiroman
Copy link
Contributor Author

Oh and of course, when there is not previous selection, the new one doesn't start

@DHowett-MSFT DHowett-MSFT added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 24, 2019
@DHowett-MSFT DHowett-MSFT added the Help Wanted We encourage anyone to jump in on these. label Jun 24, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Jun 24, 2019
@ghost ghost added the In-PR This issue has a related PR label Jul 2, 2019
@ghost ghost removed the In-PR This issue has a related PR label Dec 3, 2019
@zadjii-msft zadjii-msft added the Priority-3 A description (P3) label Jan 22, 2020
@carlos-zamora
Copy link
Member

carlos-zamora commented Jan 28, 2020

/dup #4282

@ghost
Copy link

ghost commented Jan 28, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jan 28, 2020
@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jan 28, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants