Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declaration of the keybinding is lost after saving #1411

Closed
mrmlnc opened this issue Jun 22, 2019 · 3 comments
Closed

Declaration of the keybinding is lost after saving #1411

mrmlnc opened this issue Jun 22, 2019 · 3 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@mrmlnc
Copy link

mrmlnc commented Jun 22, 2019

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.175]
Windows Terminal version (if applicable): 0.2.1715.0

Steps to reproduce

  • Open settings
  • Change keys for the nextTab action: ctrl+tab → alt+}.
  • Save settings
  • Reload terminal
  • Open settings

Expected behavior

  • I can use alt+} as keybinding for the nextTab action.
  • Or at least I can find my declaration for the nextTab action.

Actual behavior

I cannot find a declaration for the nextTab action in the profiles.json file.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 22, 2019
@mrmlnc mrmlnc changed the title Some Declaration of the keybinding lost after saving Jun 22, 2019
@mrmlnc mrmlnc changed the title Declaration of the keybinding lost after saving Declaration of the keybinding is lost after saving Jun 22, 2019
@DHowett-MSFT
Copy link
Contributor

I bet we delete key bindings that cannot be deserialized. Thanks!

@DHowett-MSFT
Copy link
Contributor

We do.

@DHowett-MSFT DHowett-MSFT added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 24, 2019
@zadjii-msft
Copy link
Member

I'd say this is actually more accurately #1212

@zadjii-msft zadjii-msft added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. labels Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrmlnc @DHowett-MSFT @zadjii-msft