Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snippets & useCommandline don't account for grapheme clusters quite right #17419

Open
2 tasks
Tracked by #15845
zadjii-msft opened this issue Jun 11, 2024 · 0 comments
Open
2 tasks
Tracked by #15845

Snippets & useCommandline don't account for grapheme clusters quite right #17419

zadjii-msft opened this issue Jun 11, 2024 · 0 comments
Assignees
@zadjii-msft
Labels
Area-Suggestions Anything related to tasks or the suggestions UI (sxnui) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.23

Comments

@zadjii-msft
Copy link
Member

  • ActionMap.cpp@_filterToSendInput
    • Generates backspaces based on the number of characters in the commandline, which isn't quite right
  • Terminal::PreviewText (after Re-implement previewing, with the new TSF #17386 )
    • Similarly, pads out spaces on the right side of the preview, but using the string length, not string columns
@zadjii-msft zadjii-msft added this to the Terminal v1.22 milestone Jun 11, 2024
@zadjii-msft zadjii-msft self-assigned this Jun 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 11, 2024
@zadjii-msft zadjii-msft added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jun 11, 2024
This was referenced Jun 11, 2024
Open
Merged
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Area-Suggestions Anything related to tasks or the suggestions UI (sxnui) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Suggestions Anything related to tasks or the suggestions UI (sxnui) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.23
Development

No branches or pull requests
3 participants
@DHowett @carlos-zamora @zadjii-msft