Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding Ctrl-C to "copy" prevents using Ctrl-C for cancelling a command #2210

Closed
hach-que opened this issue Aug 3, 2019 · 5 comments
Closed
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@hach-que
Copy link

hach-que commented Aug 3, 2019

Description of the new feature/enhancement

Right now when you add the following to your keybindings:

{
                "command" : "copy",
                "keys" : 
                [
                    "ctrl+c"
                ]
            },

It prevents Ctrl-C from terminating processes, even when there's no current text selection.

If I remove the keybinding (or change it to "ctrl+shift+c"), then I get my Ctrl-C for terminating processes back, but lose the ability to copy with Ctrl-C when text is selected.

Compare this with the current command prompt, where pressing Ctrl-C when no text is selected cancels/terminates whatever process is running, while pressing Ctrl-C with text selected copies the text.

My guess is that keybindings probably need to have an extra additional option for "this keybinding is only active while text is selected".

@hach-que hach-que added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 3, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 3, 2019
@Luuk34
Copy link

Luuk34 commented Aug 3, 2019

This is fixed in 0.3,
"copy" is now bound to "ctrl+shift+c"
(see #2014, # 2014, #1093, and possibly others...)

@hach-que
Copy link
Author

hach-que commented Aug 3, 2019

I don't want to use Ctrl-Shift-C for copy; I'd like to use Ctrl-C for copy when I have text selected, as I can in both the native Windows terminal and ConEmu (as well as Ctrl-C being "copy" in every other Windows application).

@mehmetilker
Copy link

ctrl+shift+c still does not work.

Ctrl+c is a standard is another thing... And one of the most important thing we can expect from shell environment. There should be a way to extract info...

Version: 0.3.2142.0

@DHowett-MSFT
Copy link
Contributor

The copy key handler should be returning false if there was no active selection.

@DHowett-MSFT DHowett-MSFT added this to the Terminal 1908.1 milestone Aug 5, 2019
@DHowett-MSFT DHowett-MSFT added Area-Input Related to input processing (key presses, mouse, etc.) Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 5, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 5, 2019
@zadjii-msft
Copy link
Member

zadjii-msft commented Aug 13, 2019

Oh hey, #2285 is totally a dupe of this issue, but that thread has a bit more details in it, so I'm gonna close this one as a dupe of that one.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Aug 13, 2019
@zadjii-msft zadjii-msft removed this from the Terminal 1908.1 milestone Aug 13, 2019
@zadjii-msft zadjii-msft added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Aug 13, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

5 participants