Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report Zooming causes the second line to act strange #2211

Closed
alex3305 opened this issue Aug 3, 2019 · 2 comments
Closed

Bug Report Zooming causes the second line to act strange #2211

alex3305 opened this issue Aug 3, 2019 · 2 comments
Labels
Area-VT Virtual Terminal sequence support Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.0

Comments

@alex3305
Copy link

alex3305 commented Aug 3, 2019

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.239]
Windows Terminal version (if applicable): 0.3

Steps to reproduce

  1. Make sure at least two lines exists in the terminal window (eg. by typing in a command)
  2. Use CTRL+mouse scroll wheel to zoom either in or out

Expected behavior

The buffer is not modified and the second line stays in place.

Actual behavior

100% zoom

This is expected behaviour

Powershell

image

WSL 1

image

1x zoomed in

The second line is indented

Powershell

image

WSL 1

image

1x zoomed out

The second line is indented the other way, causing the data to return to the first line.

Powershell

image

WSL 1

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 3, 2019
@zadjii-msft
Copy link
Member

Well that's insane.

Dunno what's causing this - seems like it might be in the conpty layer. Crazy that this doesn't repro for cmd.exe.

@zadjii-msft zadjii-msft added Area-VT Virtual Terminal sequence support Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Aug 5, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 5, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Aug 5, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 5, 2019
@zadjii-msft zadjii-msft added the Priority-2 A description (P2) label Jan 22, 2020
@zadjii-msft zadjii-msft mentioned this issue Jan 28, 2020
Closed
16 tasks
@zadjii-msft
Copy link
Member

Hey there was just a massive change (#4741) in this area, and I can't seem to repro this behavior anymore. I believe the next release is going to fix this, if not by #4741 then one of the other PRs in this area. If this actually isn't fixed in 0.10 (whenever that gets released), then feel free to post here and we'll re-open this one.

Thanks all!

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-VT Virtual Terminal sequence support Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.0
Development

No branches or pull requests
4 participants
@alex3305 @DHowett-MSFT @zadjii-msft @cinnamon-msft