Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word-by-word movement doesn't work in Cooked Read over conpty #3386

Closed
srv-code opened this issue Oct 31, 2019 · 8 comments
Closed

Word-by-word movement doesn't work in Cooked Read over conpty #3386

srv-code opened this issue Oct 31, 2019 · 8 comments
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Conpty For console issues specifically related to conpty

Comments

@srv-code
Copy link

srv-code commented Oct 31, 2019

Hi developers,
I really appreciate the effort spent to develop the most awaited application in Windows. I really want to see it come out of beta as a final product as soon as possible.

My suggestions for Windows Terminal:

  1. Atleast provide all the basic text editing capabilities like the word-by-word cursor navigation using Ctrl+<navigation-key-left>|<navigation-key-right> (Already present in cmd.exe).
  2. Provide the tab re-positioning capability, by dragging tab using the mouse.
  3. Text font looks little bold (a difference noticed in comparison to cmd font even after keeping the same font properties).
  4. Full-screen capability (should have already been there).
  5. Tab switcher pop-up like in other editor applications (e.g. in Visual Studio Code editor when pressed Ctrl+TAB).
  6. Auto-complete feature like in the macOS iTerm.
  7. Add "Open Windows terminal here" to Windows File Explorer right-click context menu.
  8. Support for transparency also like in cmd.exe or wsl.exe.

Thank you. Hope I get to see atleast some of the requested features/suggestions if not all.

Keep doing the awesome work!

@srv-code srv-code added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 31, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 31, 2019
@zadjii-msft
Copy link
Member

So for the record, we generally like to avoid giant issues with multiple issues reported like this one. It makes triaging and tracking the individual component issues much harder. Plus, there are already issues tracking some of the things you've mentioned here:

  1. This one actually doesn't have an issue, so I'm leaving this open for only this issue
  2. This is Add support for tab reordering #443
  3. I'm moving this discussion to Text font looks little bold in comparison to conhost #3388
  4. Feature Request: Consider supporting chromeless fullscreen mode like conhost alt+enter #531
  5. I'm moving this discussion to Tab switcher pop-up like VSCode #3389

@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conpty For console issues specifically related to conpty Area-Input Related to input processing (key presses, mouse, etc.) and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Oct 31, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 31, 2019
@zadjii-msft
Copy link
Member

(back on topic)

I've definitely noticed this in tmux with cmd.exe previously, so I'm thinking this is a conpty bug. We're probably not decoding Ctrl+Arrow keypresses exactly correctly.

Now that I'm thinking on it, maybe this is related to #2397?

@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Oct 31, 2019
@DHowett-MSFT DHowett-MSFT changed the title Word by word cursor movement Word-by-word movement doesn't work in Cooked Read over conpty Oct 31, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 31, 2019
@srv-code srv-code changed the title Word-by-word movement doesn't work in Cooked Read over conpty List of suggestions for Microsoft Windows Terminal Nov 3, 2019
@zadjii-msft
Copy link
Member

@srv-code I see that you updated your original post with additional requests, after I said that we don't want people filing issues with multiple requests in them. I'm not going to address any of those requests in this thread, please search for duplicates and file additional issues so that we can address each suggestion individually. (spoiler: there are already issues present for those suggestions.)

We're using this thread currently to track "Word-by-word movement doesn't work in Cooked Read over conpty", which is the technical reason that "basic text editing capabilities like the word-by-word cursor navigation using Ctrl+| (Already present in cmd.exe)." doesn't work in the Windows Terminal.

@zadjii-msft zadjii-msft changed the title List of suggestions for Microsoft Windows Terminal Word-by-word movement doesn't work in Cooked Read over conpty Nov 4, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Nov 16, 2019
@srv-code srv-code reopened this Nov 16, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 16, 2019
@srv-code
Copy link
Author

srv-code commented Nov 16, 2019

What is the current progress on this issue "Word-by-word movement doesn't work in Cooked Read over conpty"? Can I expect this feature to be shipping with the v1.0 release? It means a lot to me to be able to navigate naturally as in a text editor without jamming through my navigation keys. @zadjii-msft

@DHowett-MSFT
Copy link
Contributor

You will know there is progress on the issue when you see new comments or that it is closed. Right now it is in the “Terminal v1.0” milestone, which means that we want to fix it before v1.0.

@srv-code
Copy link
Author

You will know there is progress on the issue when you see new comments or that it is closed. Right now it is in the “Terminal v1.0” milestone, which means that we want to fix it before v1.0.

Thank you for your response.

@srv-code
Copy link
Author

Hi! The main issue (Atleast provide all the basic text editing capabilities like the word-by-word cursor navigation using Ctrl+| (Already present in cmd.exe)) seems to be working with the latest update (version: 0.7.3291.0) along with many other additions (e.g. ability to go full screen etc.).
I don't know if the fix was because of this thread or from someone else but I'm glad that this happened. Thank you for listening! :)

@zadjii-msft
Copy link
Member

Since this seems to be resolved, I'm closing this. I don't really know what commit fixed it. It also seems to be fixed in inbox conhost, so maybe it was never broken in conpty - it might have been a Terminal bug. Regardless, since it's gone, I'm closing this.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jan 9, 2020
@zadjii-msft zadjii-msft removed this from the Terminal v1.0 milestone Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Conpty For console issues specifically related to conpty
Projects
None yet
Development

No branches or pull requests

3 participants