Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The copy/paste line wrapping bug is back #3764

Closed
xgonc opened this issue Nov 28, 2019 · 6 comments
Closed

The copy/paste line wrapping bug is back #3764

xgonc opened this issue Nov 28, 2019 · 6 comments
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release

Comments

@xgonc
Copy link

xgonc commented Nov 28, 2019

Environment

Windows build number: 10.0.18362.10024
Windows Terminal version (if applicable): v0.7.3291.0

Steps to reproduce

Copy some text from the terminal, with multiple lines
Paste that text inside a terminal editor (tested with nano)

Expected behavior

Copy text in multiple lines, paste the same multiple lines

Actual behavior

The pasted text will be concatenated in 1 line

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 28, 2019
@xgonc xgonc changed the title Text not pasted correctly when copied on the terminal Text not pasted correctly when copied from the terminal Nov 29, 2019
@mkitzan
Copy link
Contributor

mkitzan commented Dec 2, 2019

From when I hexdump-ed a repro of this, it looks like on multi-line copy-pastes, instead of inserting a newline at the separation between lines it just adds spaces until the next line begins (as it appears on the screen). Kind of makes sense since the selection is highlighting spaces instead of jumping to the newline.
Edit: duplicate issue to #3367

Here's the hexdump of text from the top of a new CMD terminal:
cmd-prompt
hexdump

@DHowett-MSFT DHowett-MSFT changed the title Text not pasted correctly when copied from the terminal The copy/paste line wrapping bug is back Dec 2, 2019
@DHowett-MSFT
Copy link
Contributor

Say, are you copying with right-click or with the ctrl+c or ctrl+shift+c?

@DHowett-MSFT DHowett-MSFT added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 2, 2019
@mkitzan
Copy link
Contributor

mkitzan commented Dec 2, 2019

@DHowett-MSFT it behaves like that with ctrl+c or ctrl+shift+c, but it works fine with right click. What.

@xgonc xgonc closed this as completed Dec 3, 2019
@xgonc xgonc reopened this Dec 3, 2019
@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Dec 3, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 3, 2019
@mahmoudajawad
Copy link

@mkitzan, thanks for the tip. I wrote small Python script with Terminal in order to generate some long, repetitive-kind of text, I faced the wrapping bug when I copied text with ctrl+c, but right click saved the day.

@mahmoudajawad
Copy link

So new release v0.7.3382.0 has fixed the problem for me, it's mentioned in the release notes:
https://github.com/microsoft/terminal/releases/tag/v0.7.3382.0

@DHowett-MSFT
Copy link
Contributor

Thanks for confirming.

@DHowett-MSFT DHowett-MSFT added Resolution-Fix-Available It's available in an Insiders build or a release and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Projects
None yet
Development

No branches or pull requests

5 participants