Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option text (--option) same as background on Solarized Dark theme #4818

Closed
hennievn opened this issue Mar 5, 2020 · 3 comments
Closed

Option text (--option) same as background on Solarized Dark theme #4818

hennievn opened this issue Mar 5, 2020 · 3 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@hennievn
Copy link

hennievn commented Mar 5, 2020

Using Powershell, and the Solarized Dark theme, any text preceded by, and including a "-" is the same as the background color. This is assumed to be due to the definition of "background" and "brightBlack" being identical -> #002B36

Environment

Win32NT 10.0.18362.0 Microsoft Windows NT 10.0.18362.0

Any other software?


# Steps to reproduce

<!-- A description of how to trigger this bug. -->

# Expected behavior

<!-- A description of what you're expecting, possibly containing screenshots or reference material. -->
Visible text, i.e. changing the Solarized Dark "brightBlack" definition to #777777 the text displays as expected
# Actual behavior

<!-- What's actually happening? -->
Text not visible
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 5, 2020
@zadjii-msft
Copy link
Member

/dupe #4794, #4047, #2622 et. al.

@ghost
Copy link

ghost commented Mar 5, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Mar 5, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 5, 2020
@DHowett-MSFT
Copy link
Contributor

Yeah, the solution here is "we should not have shipped Solarized as a stock theme" moreso than "it is broken"

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants