Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit command doesn't close the window\tab #5040

Closed
fcingolani88 opened this issue Mar 20, 2020 · 7 comments
Closed

exit command doesn't close the window\tab #5040

fcingolani88 opened this issue Mar 20, 2020 · 7 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@fcingolani88
Copy link

fcingolani88 commented Mar 20, 2020

Windows build number: 10.0.18363.720
Windows Terminal version (if applicable): 0.10.761.0

Steps to reproduce

Type "EXIT" command after the shell reports an error about the previous command

Expected behavior

The window\tab should be closed

Actual behavior

The window\tab stays open and I can't type anything. The exit code displayed changes on different cases, maybe is related to the error reported before.

Note that this seems to happen only when the previous command terminates with an error; if the previous command is performed correctly, the EXIT command will work as expected.

image

image

Thanks

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 20, 2020
@DHowett-MSFT
Copy link
Contributor

Alas, this is a behavior that's highly conserved across multiple shells and terminal emulators on most mainstream operating systems; more info in #4223 (comment). If you'd rather it just exit every time, set closeOnExit to true. 😄 /dup #4223.

@ghost
Copy link

ghost commented Mar 20, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Mar 20, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 20, 2020
@fcingolani88
Copy link
Author

ok, but I already have closeOnExit to true. I think by default

@DHowett-MSFT
Copy link
Contributor

@fcingolani88 would you mind sharing a copy of your profiles.json file?

@fcingolani88
Copy link
Author

Sure, here you are
profiles.zip

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Mar 20, 2020

Oh, thanks! I realized my guidance is incorrect. When we changed how closeOnExit worked, we introduced some new values: "graceful", "never" and "always'. We made it so that true was the same as "graceful" (which is the behavior you're seeing.)

You'll need to set it to "always" to make sure it actually exits.

As an aside, it looks like you're using a very old version of our settings file. If you're willing to change it, now would be a great time to start over as described in Scott Hanselman's blog. If you're using older settings like those that bind Ctrl+T and Ctrl+W to new and close tab, you might need to update your new settings file with those options. Otherwise, it's a much better experience. 😄

@fcingolani88
Copy link
Author

Perfect!!
Thank you, also for Scott Hanselman's info

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants