Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider grouping font options in the json into an object #6049

Closed
Tracked by #1790
miniksa opened this issue May 20, 2020 · 2 comments
Closed
Tracked by #1790

Consider grouping font options in the json into an object #6049

miniksa opened this issue May 20, 2020 · 2 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v2.0

Comments

@miniksa
Copy link
Member

miniksa commented May 20, 2020

Is it time for us to move from fontFace to font{ face, weight, ... } or font{ family, weight ... }?

Originally posted by @DHowett in #6048 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 20, 2020
@DHowett
Copy link
Member

DHowett commented May 20, 2020

link: #1790

@carlos-zamora carlos-zamora added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels May 20, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 20, 2020
@DHowett DHowett added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 21, 2020
@DHowett DHowett added this to the Terminal v1.x milestone May 21, 2020
@DHowett
Copy link
Member

DHowett commented May 21, 2020

triage: 1.x

@be5invis be5invis mentioned this issue May 21, 2020
Open
1 task
This was referenced Jun 9, 2021
Closed
Merged
@DHowett DHowett closed this as completed in 9b9b073 Jul 1, 2021
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v2.0
Development

No branches or pull requests
4 participants
@DHowett @carlos-zamora @miniksa @cinnamon-msft