Question: Is there a way to get keybinding and convert it to string (text)?

[Chips1234]

Description of the new feature/enhancement

Is there a way to get the appkeybinding item (e.g. shortcut "Ctrl+T") and convert it to string so we can display it as tooltip/dialog label etc? Thank you in advance!

[beviu]

Maybe you can use this:

terminal/src/cascadia/TerminalApp/TerminalPage.cpp

Lines 1406 to 1411 in c0ffc9b

	auto overrideString = _FormatOverrideShortcutText(keyChord.Modifiers());
	auto mappedCh = MapVirtualKeyW(keyChord.Vkey(), MAPVK_VK_TO_CHAR);
	if (mappedCh != 0)
	{
	menuItem.KeyboardAcceleratorTextOverride(overrideString + gsl::narrow_cast<wchar_t>(mappedCh));
	}

[zadjii-msft]

Even better, I'd try KeyChordSerialization::ToString. That's what I'm using to similar effect in the command palette:

terminal/src/cascadia/TerminalApp/TerminalPage.cpp

Lines 106 to 110 in dd684cb

	auto keyChord{ _settings->GetKeybindings().GetKeyBindingForActionWithArgs(command.Action()) };
	if (keyChord)
	{
	command.KeyChordText(KeyChordSerialization::ToString(keyChord));
	}

[Chips1234]

Okay thanks!

[Chips1234]

So do I replace command with the command (example Copy)?

[Chips1234]

@zadjii-msft. So, can you please give me an example (maybe for the copyText shortcut?) Thanks!

[Chips1234]

And what should I call the method? std::wstring?

[zadjii-msft]

I'd probably just make a method on AppKeyBindings that exposed the map of KeyChord->ActionAndArgs, and I'd do something like this:

for (const auto& keyAndArgs : _settings->GetKeybindings().GetKeyMap())
{
    const auto& chord = keyAndArgs.first;
    const auto& actionAndArgs = keyAndArgs.second;
    if (keyChord) 
    { 
        auto label = KeyChordSerialization::ToString(keyChord);
        // Do something with the label here. 
        // EX: Maybe append it to a text box:
        _myTextBox.Text(fmt::format(L"{} - {}", _myTextBox.Text(), label));
    }
}

That would be easier than building every possible action and then checking if that action is bound to something.

[Chips1234]

Thanks!

[Chips1234]

@zadjii-msft I figured out the Dialog Construct from run-time part but can you maybe go to my branch on my fork and demonstrate the KeyChordSerialization::ToString part? I learn much better if I get to see it in action. Thank you so much!

[zadjii-msft]

@Chips1234 Sure.

This code is a good sample of how to add runs of text to a dialog dynamically at runtime.

Then, I'd just do the code I mentioned above to retrieve all the KeyChord's and convert them into strings of text. You can see something similar over in this branch, though, you won't be setting KeyChordText, you'll probably just be setting run.Text(KeyChordSerialization::ToString(keyChord));

[Chips1234]

Thanks

[Chips1234]

And I put the run.text where?