Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moveFocus to panel using cycle #7194

Closed
mfeiertag opened this issue Aug 5, 2020 · 2 comments
Closed

moveFocus to panel using cycle #7194

mfeiertag opened this issue Aug 5, 2020 · 2 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@mfeiertag
Copy link

mfeiertag commented Aug 5, 2020

Description of the new feature/enhancement

Currently terminal only supports moveFocus to up/down/left/right. This feature would allow cycling through panes like going trough tabs with
{ "command": "nextTab", "keys": "ctrl+tab" }
and
{ "command": "prevTab", "keys": "ctrl+shift+tab" }

Proposed technical implementation details (optional)

New panes get assigned increasing IDs.
{ "command": { "action": "moveFocus", "direction": "next" }, "keys": "ctrl+alt+tab" }
focuses the pane with the next ID
{ "command": { "action": "moveFocus", "direction": "prev" }, "keys": "ctrl+alt+shift+tab" }
focuses the pane with the previous ID

IDs could be in order of creation or in order of last used.

Property Necessity Type Default Description
paneCycleMode Optional String created Defines the order of panes when cycling. Possible values: created or lastUsed

Related to #5803 and #5464
Similar to #4692

Example (pane in focus bold):

Single Pane:
| 1 |
Duplicate pane:
| 1 | | 2 |
Pressing ctrl+alt+tab:
| 1 | | 2 |
Duplicate Pane 1, than pane 2:
| 1 | | 2 |
| 3 | | 4 |
Pressing ctrl+alt+tab would go to pane 1:
| 1 | | 2 |
| 3 | | 4 |
Pressing ctrl+alt+shift+tab would go back to pane 4:
| 1 | | 2 |
| 3 | | 4 |
Pressing ctrl+alt+shift+tab again would go to pane 3:
| 1 | | 2 |
| 3 | | 4 |

@mfeiertag mfeiertag added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 5, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 5, 2020
@mfeiertag
Copy link
Author

Duplicate of #2871

@zadjii-msft
Copy link
Member

Wow this is a super well written write-up. I love that it also includes an affordance for MRU-order pane switching as well. I'm gonna slap the body of this into a comment in #2871. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants