Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pane opening animation should not flash the default pane backdrop #7365

Open
zadjii-msft opened this issue Aug 21, 2020 · 0 comments
Open

Pane opening animation should not flash the default pane backdrop #7365

zadjii-msft opened this issue Aug 21, 2020 · 0 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@zadjii-msft
Copy link
Member

follow up to #7364

When we open a new pane there's a brief time when you can see the pane background color as the new pane slides in. This is because we immediately create the Row/Col definitions, so even if we animate the first pane getting smaller, the first pane only has half the parent grid to render into.

A solution we could do is use the background brush from the first child as the background of the parent pane, until the animation is finished. Then revert back to transparent. This will make the backgroud behind the pane sliding in look like it's the same as the first pane. This won't really help for background images, but I think this is a reasonable compromise.

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) labels Aug 21, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Aug 21, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 21, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 21, 2020
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants