Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Create Profiles Groups in 'New Tab' Drop-Down Profile Menu #7672

Closed
folsom opened this issue Sep 18, 2020 · 5 comments
Closed

Ability to Create Profiles Groups in 'New Tab' Drop-Down Profile Menu #7672

folsom opened this issue Sep 18, 2020 · 5 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@folsom
Copy link

folsom commented Sep 18, 2020

Description of the new feature/enhancement

I have a lot of profiles, such that the drop-down menu listing of them runs off the bottom of my screen and requires scrolling to reach those at the bottom.

I'd like to be able to construct groupings of profiles within the 'settings.json' file such that the group would have a name that would show up in the main drop-down, with its own drop-down menu listing the contained profiles.

Proposed technical implementation details

Here is an example 'profiles' object with a 'list' containing a 'group' object as a member that names and defines a group of profiles:

{
   "profiles":{
      "defaults":{
         "useAcrylic":true,
         "acrylicOpacity":0.7,
         "cursorShape":"filledBox",
         "cursorColor":"#00FF00",
         "closeOnExit":true
      },
      "list":[
         "group":{
            "name":"Profile Group",
            "members":[
               {
                  "guid":"{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                  "name":"Windows PowerShell",
                  "commandline":"powershell.exe",
                  "hidden":true
               },
               {
                  "guid":"{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                  "name":"Command Prompt",
                  "commandline":"cmd.exe",
                  "hidden":false
               }
            ]
         },
         {
            "guid":"{574e775e-4f2a-5b96-ac1e-a2962a402336}",
            "hidden":false,
            "name":"PowerShell",
            "colorScheme":"Campbell Powershell",
            "source":"Windows.Terminal.PowershellCore"
         }
      ]
   }
}

Given the above, there would be a 'Profile Group' listed in the New Tab drop-down, with an arrow to the right indicating a sub-menu. Hovering or clicking on the sub-menu would display profile names 'Windows PowerShell' and 'Command Prompt'.

The 'group' object could also have other contained properties that would define characteristics of the profile name in the New Tab drop-down--probably identical to the properties used for the profile name display itself.

The 'group' object could also contain other 'group' objects that would define sub-groups within the top-level group, with some reasonable limit to group nesting.

@folsom folsom added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 18, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 18, 2020
@DHowett
Copy link
Member

DHowett commented Sep 18, 2020

Thanks for writing this up! It looks like we've got some of this covered in #1571, and a spec accepted in #5888 😄

I'm gonna close this one out as a duplicate.

@DHowett DHowett closed this as completed Sep 18, 2020
@DHowett DHowett added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 18, 2020
@lakani
Copy link

lakani commented Oct 29, 2023

is this really implemented , it doesn't exists in Version: 1.18.2681.0

@zadjii-msft
Copy link
Member

@lakani It sure is! #1571 was closed by #13763, which shipped in 1.17.

See: https://learn.microsoft.com/en-us/windows/terminal/customize-settings/appearance#new-tab-dropdown

@lakani
Copy link

lakani commented Oct 29, 2023

many thanks, it works now

@folsomke
Copy link

@lakani ...thanks for checking on this and @zadjii-msft ...thanks for the link to the documentation. This is a great addition to Windows Terminal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

5 participants