Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a pane while another is animating locks it to a smaller size forever #7942

Open
DHowett opened this issue Oct 16, 2020 · 3 comments
Open
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@DHowett
Copy link
Member

DHowett commented Oct 16, 2020

1.5.2892.0.

If I go crazy on alt-shift-+, I get this:

image

@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels Oct 16, 2020
@DHowett DHowett added this to the Terminal v1.5 milestone Oct 16, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 16, 2020
@DHowett
Copy link
Member Author

DHowett commented Oct 16, 2020

Tentative 1.5; @zadjii-msft to unmark Triage if he agrees with that.
P3 because there's a workaround. The workaround is "don't do that, you're just trying to break it."

@skyline75489
Copy link
Collaborator

The workaround is "don't do that, you're just trying to break it."

One of the best workaround I've heard for a very long time 😄

@zadjii-msft
Copy link
Member

Wow you really have to slap that + quickly to get this to happen. I'm definitely seeing this too. I'm thinking fixes are either:

  1. Don't allow the creation of new children while the animation is playing (take the _createCloseLock at the start, and release it at the end)
  2. Cancel (?) the animation if a child split is requested. I'm unsure if that would immediately snap the animation to the completed state or not, but I suppose it wouldn't be that hard to stash away the Completed function, and just call it immediately.

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 21, 2020
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants