Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Rule request: mocha-avoid-skip #380

Closed
jesskelsall opened this issue Jul 4, 2017 · 3 comments
Closed

Rule request: mocha-avoid-skip #380

jesskelsall opened this issue Jul 4, 2017 · 3 comments
Labels
Difficulty: Medium People with non-trivial experience in TSLint should be able to send a pull request for this issue. Status: Accepting PRs Type: Breaking Change Type: Rule Feature Adding a feature to an existing rule.

Comments

@jesskelsall
Copy link

Pretty straightforward, disallow use of Mocha's .skip() method on tests.

Like with mocha-avoid-only, its benefit would be to stop temporary code making it into a build, preventing tests from being ran.

I'd imagine this isn't too different to mocha-avoid-only to implement.

@JoshuaKGoldberg
Copy link

Indeed, very similar to the existing mocha-avoid-only rule and a great idea for the same reasons. It would be easiest IMO to add to that rule and rename it to something more generic (it's also valid for other test runners with the same variable names).

Perhaps test-restriction-methods? test-restrictors? 😕

@JoshuaKGoldberg JoshuaKGoldberg added Status: Accepting PRs Difficulty: Medium People with non-trivial experience in TSLint should be able to send a pull request for this issue. Type: Breaking Change Type: Rule Feature Adding a feature to an existing rule. labels Jul 6, 2018
@reduckted
Copy link
Contributor

Just linking #455 here since you mentioned it could be generalized.

@JoshuaKGoldberg
Copy link

☠️ It's time! ☠️

Per #876, this repository is no longer accepting feature pull requests. TSLint is being deprecated and we recommend you switch to https://typescript-eslint.io.

Thanks for open sourcing with us, everyone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Difficulty: Medium People with non-trivial experience in TSLint should be able to send a pull request for this issue. Status: Accepting PRs Type: Breaking Change Type: Rule Feature Adding a feature to an existing rule.
Projects
None yet
Development

No branches or pull requests

3 participants