Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake find_package(wxWidgets) fails with vcpkg wxwidgets package #15106

Closed
LegalizeAdulthood opened this issue Dec 14, 2020 · 3 comments
Closed
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@LegalizeAdulthood
Copy link

Describe the bug
vcpkg builds and installs wxwidgets but CMake find_package can't locate wxwidgets from vcpkg package

Environment

  • OS: Windows
  • Compiler: VS 2019

To Reproduce
Steps to reproduce the behavior:

  1. Unpack attached zip example-wxwidgets.zip
  2. Run CMake with the vcpkg toolchain file to generate a build
  3. CMake fails at configure time attempting to find wxwidgets because setup.h is in the wrong directory (see my comments on this related issue and this pull request)

Expected behavior
The package created by vcpkg should be compatible with existing CMake wxWidgets find modules.

Failure logs

  • See attached zip

Additional context
n/a

@LegalizeAdulthood
Copy link
Author

Since this fails at configure time, a regression test case would simply build vcpkg and attempt to configure the example in the ZIP.
The example is 'Hello World!" from the wxwidgets.org site. If the configure step in CMake succeeds, then we successfully found wxWidgets via find_package from the package created by vcpkg.

@LegalizeAdulthood
Copy link
Author

OK, it seems that wxWidgets find modules expect a directory layout that is similar to what you get after a build of wxWidgets and vcpkg is re-organizing the entire directory tree, confusing the find modules.

I don't think vcpkg should be reorganizing the directories into a form not recognized by the find modules in CMake.

@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 15, 2020
@NancyLi1013
Copy link
Contributor

Hi @LegalizeAdulthood

Thanks for posting this issue.

It's duplicated to #4756, which will be fixed via PR #13361.

Let's move the attention to #4756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

No branches or pull requests

2 participants