You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
If you install libjpeg-turbo and use it to load an image with boost-gil, following the usage instructions shown upon cmake generation will result in tons of compile errors with missing libjpeg symbols as it instructs you:
libjpeg-turbo is compatible with built-in implementation-agnostic CMake targets:
find_package(JPEG REQUIRED)
target_include_directories(main PRIVATE JPEG::JPEG)
When actually, the jpeg.lib library itself will not be linked unless you instead use
target_link_libraries(main PRIVATE JPEG::JPEG)
If you link it that way, everything works fine. Unless I'm missing something, this looks like some sort of oversight.
Proposed solution
Update the usage instructions on libjpeg-turbo (this file here) to recommend target_link_libraries, which works, instead of target_include_directories, which does not work.
I will do it myself if I can get confirmation that this is in fact the problem and proper solution. It appears that way to me, but I'm not exactly a cmake expert so I thought I should clarify first.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
If you install
libjpeg-turbo
and use it to load an image withboost-gil
, following the usage instructions shown upon cmake generation will result in tons of compile errors with missinglibjpeg
symbols as it instructs you:When actually, the
jpeg.lib
library itself will not be linked unless you instead useIf you link it that way, everything works fine. Unless I'm missing something, this looks like some sort of oversight.
Proposed solution
Update the usage instructions on
libjpeg-turbo
(this file here) to recommendtarget_link_libraries
, which works, instead oftarget_include_directories
, which does not work.I will do it myself if I can get confirmation that this is in fact the problem and proper solution. It appears that way to me, but I'm not exactly a cmake expert so I thought I should clarify first.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: