[openvino] Support build with OpenCL v2023.12.14+ #36724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-lavrenov
approved these changes
Feb 13, 2024
data-queue
reviewed
Feb 14, 2024
ports/openvino/portfile.cmake
Outdated
| @@ -1,3 +1,9 @@ | |||
| vcpkg_download_distfile(PR_22011_PATH | |||
| URLS "https://patch-diff.githubusercontent.com/raw/openvinotoolkit/openvino/pull/22011.diff" | |||
There was a problem hiding this comment.
Needs ?full_index=1 for a stable hash, see #33305
There was a problem hiding this comment.
Oh I knew the issue but couldn't find the PR. Appreciate the comment 👍
Suggested change
| URLS "https://patch-diff.githubusercontent.com/raw/openvinotoolkit/openvino/pull/22011.diff" | |
| URLS "https://patch-diff.githubusercontent.com/raw/openvinotoolkit/openvino/pull/22011.diff?full_index=1" |
There was a problem hiding this comment.
Is "patch-diff.githubusercontent.com" really public/stable, or should we prefer a direct "github.com" reference?
git grep full_index for examples.
i.e. https://github.com/openvinotoolkit/openvino/pull/22011.diff?full_index=1
There was a problem hiding this comment.
I just copy-pasted the copied address for raw view. I think github.com is more portable one. let me change it
There was a problem hiding this comment.
Applied the changes in e05f5d6
data-queue
approved these changes
Feb 14, 2024
TomKatom
pushed a commit
to TomKatom/vcpkg
that referenced
this pull request
Feb 23, 2024
* [openvino] fix cl_platform_id error * [openvino] update baseline * [openvino] change from PR 22011 * see openvinotoolkit/openvino#22011 * Update ports/openvino/portfile.cmake * [openvino] overwrite version * [openvino] use github.com for patch URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a build error from
openvinoafter OpenCL port updates in my vcpkg registry.In the source of OpenVINO,
https://github.com/openvinotoolkit/openvino/blob/ceeafaf64f346c6f14a67c612e131da5c27ef620/src/plugins/intel_gpu/src/runtime/ocl/ocl_device_detector.cpp#L226-L231
The type
cl::Platform(fromdevice.getInfo<CL_DEVICE_PLATFORM>()) can't be converted tocl_platform_idimplicitly.Changes
Bring the PR to the patch for
openvino.The change seems to be applied in the next 2024 release.
References
Future works of PR
openvinoopenvinois supported...)Checklist
./vcpkg x-add-version --alland committing the result.