Handle IAsyncEnumerable and ValueTask returning methods in VSTHRD103 #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [Microsoft.Diagnostics.Runtime](https://github.com/Microsoft/clrmd) from 2.0.145301 to 2.0.151903. - [Release notes](https://github.com/Microsoft/clrmd/releases) - [Changelog](https://github.com/microsoft/clrmd/blob/master/doc/ReleaseNotes2.0.md) - [Commits](https://github.com/Microsoft/clrmd/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This corrects a regression made earlier in this branch.
Shouldn't this call `DisposeAsync` or is there some compiler magic happening?
…iter` Reverts part of 44d9db7
Update VSTHRD112.md to call `DisposeAsync` on `System.IAsyncDisposable`
|
@cezarypiatek How would a change to VSTHRD103 fix a bug in VSTHRD002? |
|
Ah, I see. #633 incorrectly believes that VSTHRD002 would report the diagnostic, but really it is VSTHRD103's responsibility. :) |
AArnott
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
The fix looks good. I've written a test to repro #633 and a ValueTask returning variant of it, as this PR suggests. The test change led to a regression in another test, so I'm working to fix that, then I will merge this PR. Thank you!
|
Thanks for merging |
This was referenced Mar 12, 2021
Bump Microsoft.VisualStudio.Threading.Analyzers from 16.7.54 to 16.9.60
BioWareRu/BioEngine.Core#420
Closed
Merged
Bump Microsoft.VisualStudio.Threading.Analyzers from 16.8.55 to 16.9.60
VahidN/DNTCommon.Web.Core#36
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this might fix #633