Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to detach a storage account with an error #1045

Closed
v-xinda opened this issue May 7, 2022 · 4 comments · Fixed by #1103
Closed

Fail to detach a storage account with an error #1045

v-xinda opened this issue May 7, 2022 · 4 comments · Fixed by #1103
Assignees
@alexweininger
Labels
AT-CTI Created by CTI team 🐛 bug emulator
Milestone
0.15.0

Comments

@v-xinda
Copy link

v-xinda commented May 7, 2022 •
edited
Loading

OS: Windows / Linux
Azure Resource Extension Build Version: 20220505.12 (unified)
Azure Storage Extension Build Version: 20220505.2 (unified)
Regression: Not a regression

Repro Steps:

  1. Attached a storage account -> Right click this storage account -> Click "Detach Storage Account".
  2. Check whether succeeds to detach this storage account.

Expect:
Succeed to detach this storage account.

Actual:
Fail to detach this storage account with an error.
image

More Info:

  1. There is an error under the "Attached Storage Accounts" node after refreshing the workspace view.
    image
  2. This issue doesn't reproduce on Mac.
@v-xinda v-xinda added AT-CTI Created by CTI team unified labels May 7, 2022
@alexweininger alexweininger added this to the Build milestone May 11, 2022
@nturinski
Copy link
Member

This is reproducing on the release version of the extension. Makes me think it has to do something with VS Code rather than us. Is it possible that this also was a result of upgrading to Node 14 and we just never caught it?

@alexweininger
Copy link
Member

a result of upgrading to Node 14 and we just never caught it?

Node 14 Node 16

@alexweininger alexweininger removed this from the Build milestone May 16, 2022
@nturinski
Copy link
Member

Can confirm that this is a result of upgrading to Node 16. Detatch and Delete Postgres Server... both work on this version of VS Code.

@nturinski nturinski mentioned this issue May 17, 2022
Closed
@alexweininger
Copy link
Member

Better start reading! 😄 https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V16.md

@alexweininger alexweininger added this to the 0.15.0 milestone Jun 8, 2022
@alexweininger alexweininger mentioned this issue Aug 10, 2022
Merged
@alexweininger alexweininger mentioned this issue Sep 2, 2022
Merged
@nturinski nturinski mentioned this issue Sep 15, 2022
Closed
@microsoft microsoft locked and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexweininger alexweininger

Labels
AT-CTI Created by CTI team 🐛 bug emulator
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Replace keytar with SecretStorage microsoft/vscode-azurestorage
3 participants
@nturinski @alexweininger @v-xinda