Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some hardcoded (previsously made optional) directives were brought back #1956

Closed
pedrolimasi opened this issue Jun 28, 2021 · 1 comment
Closed
Milestone

Comments

@pedrolimasi
Copy link
Contributor

Brief Issue Summary

Commit 4293388 brought back the ctest hardcoded directives '-T', 'test', '--output-on-failure' which were made optional on PR #1729. Some of the code we wrote was kept, though. Should I interpret this as an accident?

Quick fix

It seems from my side that fixing it will just be a matter of deleting them from here:

ctestArgs = [`-j${this.ws.config.numCTestJobs}`, '-C', configuration, '-T', 'test', '--output-on-failure'].concat(
this.ws.config.ctestDefaultArgs, this.ws.config.ctestArgs);

I would've submit a pull request, but if this is all it takes to fix it you guys should get to it much faster than I

@bobbrow
Copy link
Member

bobbrow commented Jun 28, 2021

It looks like an incorrect merge happened. Thanks for spotting this!

@bobbrow bobbrow added this to the 1.8.0 milestone Oct 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants