1.8.0 breaks command substitutions in launch.json

[fbridault]

Brief Issue Summary

I used to employ many cmake command substitutions to launch and debug targets in my projects. Since 1.8.0, this no longer works. Reverting the extension to 1.7.3 solves the problem.

Expected:

1. Use for instance ${command:cmake.buildDirectory} in the "program" property of a target in launch.json (or any command:cmake* variable in any property)
2. Select this target and click on play button, or press F5
3. Programs launches

Apparent Behavior:

1. Use for instance ${command:cmake.buildDirectory} in the "program" attribute of a target in launch.json
2. Select this target and click on play button, or press F5
3. Programs does not launch, the debug bar very briefly pops in and immediately out. No error message is displayed anywhere.

CMake Tools Log

Not relevant I guess, the log is not filled in when launching a target.

Developer Tools Log

Nothing moves in the log when trying to launch a target, but here is the log of extensions:

[2021-08-30 11:07:56.659] [exthost] [info] extension host started
[2021-08-30 11:07:56.659] [exthost] [info] Skipping acquiring lock for /home/fbridault/.config/Code/User/workspaceStorage/02745f54f69c82dedef436d43c94ae52.
[2021-08-30 11:07:56.984] [exthost] [info] ExtensionService#_doActivateExtension vscode.microsoft-authentication {"startup":false,"extensionId":{"value":"vscode.microsoft-authentication","_lower":"vscode.microsoft-authentication"},"activationEvent":"onAuthenticationRequest:microsoft"}
[2021-08-30 11:07:56.985] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/microsoft-authentication/dist/extension.js
[2021-08-30 11:07:57.038] [exthost] [info] ExtensionService#_doActivateExtension redhat.vscode-xml {"startup":false,"extensionId":{"value":"redhat.vscode-xml","_lower":"redhat.vscode-xml"},"activationEvent":"onLanguage:xml"}
[2021-08-30 11:07:57.038] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/redhat.vscode-xml-0.18.0/dist/extension
[2021-08-30 11:07:57.078] [exthost] [info] ExtensionService#_doActivateExtension vscode.debug-auto-launch {"startup":true,"extensionId":{"value":"vscode.debug-auto-launch","_lower":"vscode.debug-auto-launch"},"activationEvent":"*"}
[2021-08-30 11:07:57.078] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/debug-auto-launch/dist/extension
[2021-08-30 11:07:57.084] [exthost] [info] ExtensionService#_doActivateExtension vscode.git {"startup":true,"extensionId":{"value":"GitLab.gitlab-workflow","_lower":"gitlab.gitlab-workflow"},"activationEvent":"*"}
[2021-08-30 11:07:57.084] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/git/dist/main
[2021-08-30 11:07:57.152] [exthost] [info] ExtensionService#_doActivateExtension actboy168.tasks {"startup":true,"extensionId":{"value":"actboy168.tasks","_lower":"actboy168.tasks"},"activationEvent":"*"}
[2021-08-30 11:07:57.153] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/actboy168.tasks-0.9.0/extension.js
[2021-08-30 11:07:57.154] [exthost] [info] ExtensionService#_doActivateExtension johnpapa.vscode-peacock {"startup":true,"extensionId":{"value":"johnpapa.vscode-peacock","_lower":"johnpapa.vscode-peacock"},"activationEvent":"*"}
[2021-08-30 11:07:57.154] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/johnpapa.vscode-peacock-3.9.1/dist/extension
[2021-08-30 11:07:57.161] [exthost] [info] ExtensionService#_doActivateExtension mhutchie.git-graph {"startup":true,"extensionId":{"value":"mhutchie.git-graph","_lower":"mhutchie.git-graph"},"activationEvent":"*"}
[2021-08-30 11:07:57.161] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/mhutchie.git-graph-1.30.0/out/extension.js
[2021-08-30 11:07:57.192] [exthost] [info] ExtensionService#_doActivateExtension streetsidesoftware.code-spell-checker {"startup":true,"extensionId":{"value":"streetsidesoftware.code-spell-checker","_lower":"streetsidesoftware.code-spell-checker"},"activationEvent":"*"}
[2021-08-30 11:07:57.192] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/streetsidesoftware.code-spell-checker-1.10.2/dist/extension.js
[2021-08-30 11:07:57.226] [exthost] [info] ExtensionService#_doActivateExtension yzhang.markdown-all-in-one {"startup":true,"extensionId":{"value":"yzhang.markdown-all-in-one","_lower":"yzhang.markdown-all-in-one"},"activationEvent":"workspaceContains:README.md"}
[2021-08-30 11:07:57.226] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/yzhang.markdown-all-in-one-3.4.0/dist/extension
[2021-08-30 11:07:57.309] [exthost] [info] ExtensionService#_doActivateExtension vscode.markdown-math {"startup":false,"extensionId":{"value":"yzhang.markdown-all-in-one","_lower":"yzhang.markdown-all-in-one"},"activationEvent":"api"}
[2021-08-30 11:07:57.309] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/markdown-math/dist/extension
[2021-08-30 11:07:57.367] [exthost] [info] ExtensionService#_doActivateExtension ms-vscode.cmake-tools {"startup":true,"extensionId":{"value":"ms-vscode.cmake-tools","_lower":"ms-vscode.cmake-tools"},"activationEvent":"workspaceContains:**/CMakeLists.txt"}
[2021-08-30 11:07:57.367] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/ms-vscode.cmake-tools-1.8.0/dist/main
[2021-08-30 11:07:57.623] [exthost] [info] ExtensionService#_doActivateExtension vscode.grunt {"startup":false,"extensionId":{"value":"vscode.grunt","_lower":"vscode.grunt"},"activationEvent":"onCommand:workbench.action.tasks.runTask"}
[2021-08-30 11:07:57.623] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/grunt/dist/main
[2021-08-30 11:07:57.628] [exthost] [info] ExtensionService#_doActivateExtension vscode.gulp {"startup":false,"extensionId":{"value":"vscode.gulp","_lower":"vscode.gulp"},"activationEvent":"onCommand:workbench.action.tasks.runTask"}
[2021-08-30 11:07:57.628] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/gulp/dist/main
[2021-08-30 11:07:57.631] [exthost] [info] ExtensionService#_doActivateExtension vscode.jake {"startup":false,"extensionId":{"value":"vscode.jake","_lower":"vscode.jake"},"activationEvent":"onCommand:workbench.action.tasks.runTask"}
[2021-08-30 11:07:57.631] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/jake/dist/main
[2021-08-30 11:07:57.634] [exthost] [info] ExtensionService#_doActivateExtension vscode.npm {"startup":false,"extensionId":{"value":"vscode.npm","_lower":"vscode.npm"},"activationEvent":"onCommand:workbench.action.tasks.runTask"}
[2021-08-30 11:07:57.634] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/npm/dist/npmMain
[2021-08-30 11:07:57.661] [exthost] [info] ExtensionService#_doActivateExtension vscode.typescript-language-features {"startup":false,"extensionId":{"value":"vscode.typescript-language-features","_lower":"vscode.typescript-language-features"},"activationEvent":"onCommand:workbench.action.tasks.runTask"}
[2021-08-30 11:07:57.661] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/typescript-language-features/dist/extension
[2021-08-30 11:07:57.900] [exthost] [info] ExtensionService#_doActivateExtension ms-vscode.js-debug {"startup":false,"extensionId":{"value":"ms-vscode.js-debug","_lower":"ms-vscode.js-debug"},"activationEvent":"onCommand:extension.js-debug.clearAutoAttachVariables"}
[2021-08-30 11:07:57.901] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/ms-vscode.js-debug/src/extension.js
[2021-08-30 11:07:58.118] [exthost] [info] ExtensionService#_doActivateExtension vscode.github {"startup":false,"extensionId":{"value":"vscode.github","_lower":"vscode.github"},"activationEvent":"*"}
[2021-08-30 11:07:58.118] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/github/dist/extension.js
[2021-08-30 11:07:58.129] [exthost] [info] ExtensionService#_doActivateExtension GitLab.gitlab-workflow {"startup":false,"extensionId":{"value":"GitLab.gitlab-workflow","_lower":"gitlab.gitlab-workflow"},"activationEvent":"*"}
[2021-08-30 11:07:58.129] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/gitlab.gitlab-workflow-3.29.1/out/src/extension
[2021-08-30 11:07:58.451] [exthost] [warning] [redhat.vscode-xml] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for '[xml]', provide the URI of a resource or 'null' for any resource.
[2021-08-30 11:07:59.020] [exthost] [info] ExtensionService#_doActivateExtension vscode.configuration-editing {"startup":false,"extensionId":{"value":"vscode.configuration-editing","_lower":"vscode.configuration-editing"},"activationEvent":"onLanguage:jsonc"}
[2021-08-30 11:07:59.020] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/configuration-editing/dist/configurationEditingMain
[2021-08-30 11:07:59.028] [exthost] [info] ExtensionService#_doActivateExtension vscode.json-language-features {"startup":false,"extensionId":{"value":"vscode.json-language-features","_lower":"vscode.json-language-features"},"activationEvent":"onLanguage:jsonc"}
[2021-08-30 11:07:59.028] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/json-language-features/client/dist/node/jsonClientMain
[2021-08-30 11:07:59.080] [exthost] [info] ExtensionService#_doActivateExtension ms-azuretools.vscode-docker {"startup":false,"extensionId":{"value":"ms-azuretools.vscode-docker","_lower":"ms-azuretools.vscode-docker"},"activationEvent":"onCommand:workbench.action.tasks.runTask"}
[2021-08-30 11:07:59.080] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/ms-azuretools.vscode-docker-1.16.0/main
[2021-08-30 11:07:59.431] [exthost] [info] ExtensionService#_doActivateExtension vscode.github-authentication {"startup":false,"extensionId":{"value":"vscode.github-authentication","_lower":"vscode.github-authentication"},"activationEvent":"onAuthenticationRequest:github"}
[2021-08-30 11:07:59.432] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/github-authentication/dist/extension.js
[2021-08-30 11:07:59.778] [exthost] [info] eager extensions activated
[2021-08-30 11:07:59.806] [exthost] [info] ExtensionService#_doActivateExtension vscode.emmet {"startup":false,"extensionId":{"value":"vscode.emmet","_lower":"vscode.emmet"},"activationEvent":"onStartupFinished"}
[2021-08-30 11:07:59.806] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/emmet/dist/node/emmetNodeMain
[2021-08-30 11:07:59.823] [exthost] [info] ExtensionService#_doActivateExtension vscode.merge-conflict {"startup":false,"extensionId":{"value":"vscode.merge-conflict","_lower":"vscode.merge-conflict"},"activationEvent":"onStartupFinished"}
[2021-08-30 11:07:59.824] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/merge-conflict/dist/mergeConflictMain
[2021-08-30 11:07:59.827] [exthost] [info] ExtensionService#_doActivateExtension alefragnani.Bookmarks {"startup":false,"extensionId":{"value":"alefragnani.Bookmarks","_lower":"alefragnani.bookmarks"},"activationEvent":"onStartupFinished"}
[2021-08-30 11:07:59.827] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/alefragnani.bookmarks-13.1.0/dist/extension
[2021-08-30 11:07:59.834] [exthost] [info] ExtensionService#_doActivateExtension CoenraadS.bracket-pair-colorizer-2 {"startup":false,"extensionId":{"value":"CoenraadS.bracket-pair-colorizer-2","_lower":"coenraads.bracket-pair-colorizer-2"},"activationEvent":"onStartupFinished"}
[2021-08-30 11:07:59.834] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/coenraads.bracket-pair-colorizer-2-0.2.1/out/src/extension
[2021-08-30 11:07:59.850] [exthost] [info] ExtensionService#_doActivateExtension dbaeumer.vscode-eslint {"startup":false,"extensionId":{"value":"dbaeumer.vscode-eslint","_lower":"dbaeumer.vscode-eslint"},"activationEvent":"onStartupFinished"}
[2021-08-30 11:07:59.850] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/dbaeumer.vscode-eslint-2.1.23/client/out/extension
[2021-08-30 11:07:59.872] [exthost] [info] ExtensionService#_doActivateExtension eamodio.gitlens {"startup":false,"extensionId":{"value":"eamodio.gitlens","_lower":"eamodio.gitlens"},"activationEvent":"onStartupFinished"}
[2021-08-30 11:07:59.873] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/eamodio.gitlens-11.6.0/dist/gitlens
[2021-08-30 11:07:59.964] [exthost] [info] ExtensionService#_doActivateExtension ms-vscode-remote.remote-containers {"startup":false,"extensionId":{"value":"ms-vscode-remote.remote-containers","_lower":"ms-vscode-remote.remote-containers"},"activationEvent":"onStartupFinished"}
[2021-08-30 11:07:59.964] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/ms-vscode-remote.remote-containers-0.191.1/dist/extension/extension
[2021-08-30 11:08:00.745] [exthost] [info] ExtensionService#_doActivateExtension ms-vscode.cpptools {"startup":false,"extensionId":{"value":"ms-vscode.cmake-tools","_lower":"ms-vscode.cmake-tools"},"activationEvent":"api"}
[2021-08-30 11:08:00.745] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/ms-vscode.cpptools-1.6.0/dist/main
[2021-08-30 11:33:26.341] [exthost] [warning] TextEditor is closed/disposed
[2021-08-30 11:33:46.857] [exthost] [error] [eamodio.gitlens] provider FAILED
[2021-08-30 11:33:46.857] [exthost] [error] Error: cannot open file:///home/fbridault/dev/sight/src/sight/Bundles/configs/ogreConfig/rc/configurations/OgreHistogramManager.xml. Detail: Impossible de lire le fichier '/home/fbridault/dev/sight/src/sight/Bundles/configs/ogreConfig/rc/configurations/OgreHistogramManager.xml' (Error: Impossible de résoudre le fichier non existant '/home/fbridault/dev/sight/src/sight/Bundles/configs/ogreConfig/rc/configurations/OgreHistogramManager.xml')
    at vscode-file://vscode-app/snap/code/72/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:2448:68098
[2021-08-30 12:24:50.388] [exthost] [info] ExtensionService#_doActivateExtension vscode.debug-server-ready {"startup":false,"extensionId":{"value":"vscode.debug-server-ready","_lower":"vscode.debug-server-ready"},"activationEvent":"onDebugResolve"}
[2021-08-30 12:24:50.388] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/72/usr/share/code/resources/app/extensions/debug-server-ready/dist/extension
[2021-08-30 12:25:51.766] [exthost] [warning] TextEditor is closed/disposed
[2021-08-30 12:25:59.011] [exthost] [warning] TextEditor is closed/disposed
[2021-08-30 12:30:04.273] [exthost] [info] ExtensionService#_doActivateExtension Digoro.clipboard {"startup":false,"extensionId":{"value":"Digoro.clipboard","_lower":"digoro.clipboard"},"activationEvent":"onCommand:clipboard.copy"}
[2021-08-30 12:30:04.274] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/fbridault/.vscode/extensions/digoro.clipboard-1.3.3/out/extension.js

Platform and Versions

• Operating System: Windows 10.0 and Ubuntu 21.04 (tested both)
• CMake Version: 3.19.6
• VSCode Version: 1.59.1
• CMake Tools Extension Version: 1.8.0
• Compiler/Toolchain:Visual C++ 2019 and Clang 12

Other Notes/Information

On the same computer/OS, with the same code but with a different clone a probably different VSCde settings, everything works as expected. I am trying to figure out what is the difference, but at least an error message would be expected even if I did something wrong.

[fbridault]

I might have a clue. The workspace I am working on includes two projects. If I launch either of the two projects alone in a workspace, the substitution seems to work. This seems to be the only difference, since the launch.json is the same file in both cases.

[bobbrow]

Thank you for reporting this issue. A fix was just committed for this. If you would like to help us test it, here are instructions:

1. Download the zip file from here: https://github.com/microsoft/vscode-cmake-tools/suites/3636367498/artifacts/88080542
2. Unzip the VSIX file inside.
3. Run the "Install from VSIX..." command in VS Code and select the unzipped VSIX file.

We plan to patch this soon, but the PR build should unblock you until then.

[fbridault]

Indeed this solves the issue. Many thanks for solving this so quickly.

And thanks too for this great extension ! 😄