Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support version 4 of presets #2492

Closed
elahehrashedi opened this issue Apr 11, 2022 · 5 comments · Fixed by #2544
Closed

Support version 4 of presets #2492

elahehrashedi opened this issue Apr 11, 2022 · 5 comments · Fixed by #2544
Assignees
@chausner
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets
Milestone
1.12

Comments

@elahehrashedi
Copy link
Contributor

elahehrashedi commented Apr 11, 2022 •
edited by bobbrow
Loading

Brief Issue Summary

We need to support new features added in version 4 of presets.

  • include elements
  • ${fileDir} macro
  • resolvePackageReferences

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response
@elahehrashedi elahehrashedi changed the title Support for version 4 of Json Schema Support version 4 of Json Schema Apr 11, 2022
@elahehrashedi elahehrashedi mentioned this issue Apr 11, 2022
Closed
@bobbrow bobbrow changed the title Support version 4 of Json Schema Support version 4 of presets Apr 11, 2022
@bobbrow bobbrow added enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets labels May 4, 2022
@bobbrow bobbrow mentioned this issue May 4, 2022
Closed
@chausner
Copy link
Contributor

chausner commented May 8, 2022

@elahehrashedi I can try to contribute this. Feel free to assign me to this issue.

@chausner chausner mentioned this issue May 14, 2022
Merged
@mpusz
Copy link

mpusz commented Jun 3, 2022

Recent versions of Conan now generate CMakeUserPresets.json with schema version 4 (they include other files in it). It would be great to be able to open those files with VSCode.

@chausner
Copy link
Contributor

chausner commented Jun 3, 2022

Recent versions of Conan now generate CMakeUserPresets.json with schema version 4 (they include other files in it). It would be great to be able to open those files with VSCode.

Yes, that's exactly why I contributed an implementation in #2544, still pending in review though. :) It works well for me with the files generated by Conan.

@bobbrow
Copy link
Member

bobbrow commented Jun 3, 2022

We plan to review the v4 PR next week. We were trying to finish up the last planned PR for 1.11, but had to switch over to cpptools to fix a few things for that release which set us back a little on CMake Tools. @chausner's PR will be reviewed shortly after and will be available in 1.12 pre-release. We're sorry for the delay on it.

@bobbrow bobbrow linked a pull request Jun 21, 2022 that will close this issue
Implement support for v4 presets files #2544
Merged
@bobbrow
Copy link
Member

bobbrow commented Jun 21, 2022

This feature is available in version 1.12.3 (pre-release). Thank you @chausner for submitting the PR!

@bobbrow bobbrow closed this as completed Jun 21, 2022
@bobbrow bobbrow modified the milestone: 1.12 Jun 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chausner chausner

Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: presets
Projects
None yet
Milestone
1.12
Development

Successfully merging a pull request may close this issue.

Implement support for v4 presets files chausner/vscode-cmake-tools
4 participants
@mpusz @bobbrow @chausner @elahehrashedi