The tasks' targets are not resolved when "cmake.buildTask" is used

[elahehrashedi]

Brief Issue Summary

When searching for matching tasks, we try to compare the targets.

vscode-cmake-tools/src/cmakeTaskProvider.ts

Lines 223 to 232 in b6668bd

	if (presetName) {
	matchingTargetTasks = buildTasks.filter(task => task.definition.preset === presetName);
	} else {
	matchingTargetTasks = buildTasks.filter(task => {
	const taskTargets: string[] = task.definition.targets || [];
	const inputTargets: string[] = targets || [];
	return taskTargets.length === inputTargets.length && taskTargets.every((item, index) => item === inputTargets[index]);
	});
	}

However, we don't resolve the targets such as "${command:cmake.buildTargetName}" before comparison.

[elahehrashedi]

piomis since you have contributed to this code before, do you think you can take a look at this issue? Thank you.

[piomis]

@elahehrashedi I will take a look.
Can you please provide me a way how to reproduce it?

[eseiler]

Seems to be related to #2959

As for an example, the following just runs CMake build as a task.
tasks.json:

{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "Build ",
            "command": "/usr/bin/bash",
            "args": ["-c", "${command:cmake.tasksBuildCommand}"],
            "type": "shell",
            "group": {
                "kind": "build",
                "isDefault": true
            },
            "presentation": {
                "clear": true,
                "panel": "dedicated",
                "echo": true,
                "showReuseMessage" : true
            },
            "options": {
                "cwd": "${command:cmake.buildDirectory}"
            },
            "problemMatcher": "$gcc"
        }
    ]
}

I think you need to have "cmake.buildTask": true set.

With v1.12.27, this task was detected (e.g., when building a target via the status bar button), but it is not any more with v1.13.XX. As far as I understand, the extension now defines a kind of task and checks for tasks with "type": "cmake".

Personally, I prefer using a (generic "type": "shell") task because:

• there is colored output
• tasks are run in the Terminal tab (instead of the Output tab)

But it's also handy when you need to do some things (via task's dependsOn config) before running cmake build or ctest.

[piomis]

This report is for sure not related to behaviour which you observe.
Like I wrote in #2959 - shell task behaviour was changed.
I proposed to keep #2959 to track discussion about tasks types.