Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] TypeError when running CTests with debugging #3817

Closed
tristanlabelle opened this issue Jun 5, 2024 · 3 comments · Fixed by #3814
Closed

[regression] TypeError when running CTests with debugging #3817

tristanlabelle opened this issue Jun 5, 2024 · 3 comments · Fixed by #3814
Labels
bug a bug in the product regression used to work and no longer does. Regressions are typically high priority
Milestone

Comments

@tristanlabelle
Copy link
Contributor

tristanlabelle commented Jun 5, 2024

Brief Issue Summary

Running tests with debugging from the test explorer has recently regressed to failing with

TypeError: Cannot read properties of undefined (reading 'fsPath')"

image

I attached a debugger and found that this line assumes that TestItem.uri is non-null, whereas it is in our case.

image

I'm flagging this as a regression because it just recently started happening and affecting our engineers.

CMake Tools Diagnostics

{
  "os": "win32",
  "vscodeVersion": "1.89.1",
  "cmtVersion": "1.18.41",
  "configurations": [
    {
      "folder": "c:\\Code\\<snip>",
      "cmakeVersion": "3.29.3",
      "configured": true,
      "generator": "Ninja",
      "usesPresets": true,
      "compilers": {
        "C": "clang",
        "CXX": "clang"
      }
    }
  ],
  "cpptoolsIntegration": {
    "isReady": true,
    "hasCodeModel": true,
    "activeBuildType": "Debug",
    "buildTypesSeen": [
      "Debug"
    ],
    "requests": [],
    "responses": [],
    "partialMatches": [],
    "targetCount": 303,
    "executablesCount": 8,
    "librariesCount": 265,
    "targets": []
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "always",
      "configureOnOpen": true
    }
  ]
}

Debug Log

This is unrelated to the CMake build, but a problem of the CTest integration.

Additional Information

No response

@gcampbell-msft
Copy link
Collaborator

@tristanlabelle Could you try out this PR? #3814 I've updated it to include a catch fix for this.

@gcampbell-msft gcampbell-msft added bug a bug in the product regression used to work and no longer does. Regressions are typically high priority and removed triage labels Jun 5, 2024
@gcampbell-msft gcampbell-msft added this to the Backlog milestone Jun 5, 2024
@gcampbell-msft gcampbell-msft moved this from Triage Needed to Pending Prioritization in CMake Tools Jun 5, 2024
@tristanlabelle
Copy link
Contributor Author

@gcampbell-msft , yup, that fixes it!

@gcampbell-msft
Copy link
Collaborator

@tristanlabelle This issue will be fixed in pre-release tomorrow! We also plan to release a patch official release next week.

@gcampbell-msft gcampbell-msft modified the milestones: Backlog, 1.18 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the product regression used to work and no longer does. Regressions are typically high priority
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants