CMake configure preset installDir setting is evaluated relative to the binary directory instead of the source directory #3871
Comments
|
Thanks for reporting this issue. We find that "-DCMAKE_INSTALL_PREFIX=install" in your debug log. It looks like to point to the path you set in CMakeUserPresets.json file. And we try to repro your issue using a simple project, but we didn't repro it. The target could be installed to installDir we set in CMakePresets.json, such as ENV: |
Evelyn-001
added
more info needed
|
To reproduce the issue, remove the
Note the presence of |
|
This issue could repro when set |
Evelyn-001
added
bug
|
Hi @Evelyn-001 & @Bekenn, this issue should now be fixed in the latest pre-release version of the CMake Tools extension. Let me know if it works for you, thanks! |
|
@snehara99, thanks for your reply. We verified this issue has been fixed on CMake Tools version: v1.19.22 (pre-release). Could you please verify it again? We are looking forward to hearing from you. Thanks. |
|
Thanks for the quick turnaround! I'll try to look at this tonight. |
|
We verified the issue on CMake tools: v1.19.45 and it has been fixed. ENV： Actual result: |
|
I thought I'd responded to this, but apparently not; sorry! Yes, this works for me, as well. |
|
We are glad to be hearing your issue has been solved. Thanks for your support. |
Brief Issue Summary
From the CMake documentation for the
installDirsetting:The CMake Tools extension appears to evaluate this setting relative to the binary directory. If I supply a relative path and run the configure task using the CMake Tools extension, then the resulting cache variable for
CMAKE_INSTALL_PREFIXbegins with the binary directory. If I instead invoke CMake directly with the same preset, thenCMAKE_INSTALL_PREFIXbegins with the source directory.My best guess as to the cause is that the extension runs the configure step with the current working directory set to the binary directory. Passing a relative path with
-DCMAKE_INSTALL_PREFIX=will cause CMake to form a path relative to the current working directory rather than the source directory. The CMake Tools extension should explicitly prepend the source directory in this case.CMake Tools Diagnostics
{ "os": "darwin", "vscodeVersion": "1.91.0", "cmtVersion": "1.18.42", "configurations": [ { "folder": "/Users/bekenn/Projects/altsup", "cmakeVersion": "3.29.3", "configured": true, "generator": "Ninja Multi-Config", "usesPresets": true, "compilers": { "CXX": "/opt/homebrew/opt/llvm/bin/clang++" } } ], "cpptoolsIntegration": { "isReady": false, "hasCodeModel": false, "activeBuildType": "", "buildTypesSeen": [], "requests": [], "responses": [], "partialMatches": [], "targetCount": 0, "executablesCount": 0, "librariesCount": 0, "targets": [] }, "settings": [ { "communicationMode": "automatic", "useCMakePresets": "auto", "configureOnOpen": false } ] }Debug Log
Additional Information
CMakeUserPresets.json
The text was updated successfully, but these errors were encountered: