Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick start causes second configure if automaticReconfigure is enabled #3910

Closed
qarni opened this issue Jul 16, 2024 · 1 comment · Fixed by #3933
Closed

quick start causes second configure if automaticReconfigure is enabled #3910

qarni opened this issue Jul 16, 2024 · 1 comment · Fixed by #3933
Assignees
@qarni
Labels
bug a bug in the product Feature: quick start

Comments

@qarni
Copy link
Contributor

qarni commented Jul 16, 2024 

          One thing I noticed while testing is that line 2863 (in the new version), will technically force a second configure if the `automaticReconfigure` setting is enabled. I don't think this needs to block this PR, but it is something we should look into.

Originally posted by @gcampbell-msft in #3853 (comment)
@qarni qarni self-assigned this Jul 16, 2024
@github-project-automation github-project-automation bot moved this to Triage Needed in CMake Tools Jul 16, 2024
@qarni qarni added bug a bug in the product Feature: quick start and removed triage labels Jul 16, 2024
@qarni qarni removed this from CMake Tools Jul 16, 2024
@github-project-automation github-project-automation bot moved this to Triage Needed in CMake Tools Jul 16, 2024
@gcampbell-msft gcampbell-msft moved this to Pending Prioritization in CMake Tools Jul 17, 2024
@qarni qarni changed the title setting active project again after quick start causes second configure quick start causes second configure Jul 24, 2024
@qarni qarni changed the title quick start causes second configure quick start causes second configure if automaticReconfigure is enabled Jul 24, 2024
@qarni qarni mentioned this issue Jul 24, 2024
Merged
@qarni qarni moved this from Pending Prioritization to To Do in CMake Tools Jul 24, 2024
@qarni qarni moved this from To Do to In Progress in CMake Tools Jul 24, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Completed in CMake Tools Jul 26, 2024
@v-frankwang
Copy link
Collaborator

We verified the issue on CMake tools: v1.19.45 and it has been fixed.

ENV：
CMake Tools:v1.19.45
vscode: 1.92.2

Actual result:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qarni qarni

Labels
bug a bug in the product Feature: quick start
Projects
CMake Tools
Status: Completed
Milestone
No milestone
2 participants
@qarni @v-frankwang