Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deadlock can occur when doing a Find All References (or call hierarchy) and didChangeCppProperties/didChangeCustomBrowseConfiguration is received #10855

Closed
sean-mcmanus opened this issue Apr 21, 2023 · 1 comment
Closed

Deadlock can occur when doing a Find All References (or call hierarchy) and didChangeCppProperties/didChangeCustomBrowseConfiguration is received #10855

sean-mcmanus opened this issue Apr 21, 2023 · 1 comment
Assignees
@Colengms
Labels
bug Feature: Call Hierarchy Feature: Find All References Find All References, Peek References, Rename fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone
1.16.0

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Apr 21, 2023 •
edited
Loading

The lsp processing thread becomes deadlocked waiting for the references thread to finish (which is waiting for lsp processing to finish).

Only when configured with a configuration provider.

Repros with 1.14.5 too. An easy repro is to do Find All References with a large enough case (i.e. 20+ files to confirm) and then do Rescan Workspace. Another repro is to invoke it before a configuration provider has finished sending the browse configuration.
@sean-mcmanus sean-mcmanus added bug Language Service Feature: Find All References Find All References, Peek References, Rename labels Apr 21, 2023
@sean-mcmanus sean-mcmanus added this to the 1.15 milestone Apr 21, 2023
@sean-mcmanus sean-mcmanus modified the milestones: 1.15, 1.15.3 Apr 22, 2023
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Apr 22, 2023
@sean-mcmanus sean-mcmanus mentioned this issue Apr 28, 2023
Closed
@sean-mcmanus sean-mcmanus reopened this Apr 28, 2023
@sean-mcmanus sean-mcmanus modified the milestones: 1.15.3, 1.16.0 Apr 28, 2023
@sean-mcmanus sean-mcmanus removed the fixed Check the Milestone for the release in which the fix is or will be available. label Apr 28, 2023
@sean-mcmanus sean-mcmanus pinned this issue Apr 29, 2023
@sean-mcmanus sean-mcmanus unpinned this issue May 4, 2023
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label May 9, 2023
@michelleangela
Copy link
Contributor

This is resolved in https://github.com/microsoft/vscode-cpptools/releases/tag/1.16.0.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Colengms Colengms

Labels
bug Feature: Call Hierarchy Feature: Find All References Find All References, Peek References, Rename fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Milestone
1.16.0
Development

No branches or pull requests
3 participants
@sean-mcmanus @michelleangela @Colengms