Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vcpkg code action from missing include scenarios #11252

Closed
sean-mcmanus opened this issue Jul 26, 2023 · 6 comments
Closed

Remove vcpkg code action from missing include scenarios #11252

sean-mcmanus opened this issue Jul 26, 2023 · 6 comments
Assignees
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. Language Service regression A bug that didn't exist in a previous release
Milestone

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jul 26, 2023

This used to work at some point with an internal build, but I'm not sure if it ever worked with a public release (i.e. the ones I tried all don't work).

The code action implementation is supposed to check if it's a system header and show different code actions.

You can set compilerPath to "" for a repro.

I reviewed the code and it seems to be setup to do the right thing, but it's going wrong at some point either in cpptools or the TypeScript that handles the result.

image

@sean-mcmanus sean-mcmanus added bug Language Service regression A bug that didn't exist in a previous release Feature: Configuration An issue related to configuring the extension or IntelliSense labels Jul 26, 2023
@bobbrow
Copy link
Member

bobbrow commented Jul 26, 2023

It would be nice to remove the "vcpkg" code action as part of this if possible.

@sean-mcmanus
Copy link
Contributor Author

@bobbrow You mean remove the vcpkg code action entirely? Even for non-system includes?

@bobbrow
Copy link
Member

bobbrow commented Jul 26, 2023

No, just for system includes since it's not going to help for that case (and it's actually a "bad" suggestion).

@sean-mcmanus
Copy link
Contributor Author

@bobbrow Yeah, the code already handles/checks that -- it's just a matter of figuring out why it's not working as expected (like it used to).

@browntarik
Copy link
Contributor

The edit compiler path code action appearing is expected behavior. A fix for the vcpkg code action can be found here: #11280

@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Aug 5, 2023
@sean-mcmanus sean-mcmanus added this to the 1.17.1 milestone Aug 5, 2023
@browntarik browntarik changed the title Code actions on missing includes aren't detecting system includes Remove vcpkg code action from missing include scenarios Aug 8, 2023
@michelleangela
Copy link
Contributor

Fix available in pre-release https://github.com/microsoft/vscode-cpptools/releases/tag/v1.17.1.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. Language Service regression A bug that didn't exist in a previous release
Projects
None yet
Development

No branches or pull requests

4 participants