Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeCompileCommandsNotification is sent/processed even if a configuration provider is used instead of compile commands #12889

Closed
sean-mcmanus opened this issue Oct 26, 2024 · 2 comments
Labels
bug Feature: Compile Commands Feature: Configuration Provider Related to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools. Language Service performance

Comments

@sean-mcmanus
Copy link
Contributor

It seems like it should only be sent/processed if compile commands is actually being used for configuration.

@sean-mcmanus sean-mcmanus added bug Feature: Compile Commands Feature: Configuration Provider Related to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools. Language Service performance labels Oct 26, 2024
@sean-mcmanus
Copy link
Contributor Author

If compileCommands is set, then it could still be used as a fallback if the configuration provider doesn't have a configuration for a file, but if compileCommands is not set then there's no need to send an update for one.

@Colengms
Copy link
Contributor

Colengms commented Nov 6, 2024

I don't think these notifications cause a perf issue. They simply result in a dirty flag being set on the native side, causing the compile_commands.json to be re-parsed the next time its contents are required.

It would be nice to avoid sending redundant notifications, but I think that might need to be part of a more wholistic change, to ensure changes are properly synchronized with TU creation.

We have some work (currently on the back burner) to address #6931 , which may result in the current compile_commands.json handling being replaced (processed entirely on the TypeSide side).

@Colengms Colengms closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
@github-project-automation github-project-automation bot moved this to Done in cpptools Nov 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Compile Commands Feature: Configuration Provider Related to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools. Language Service performance
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants