Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Go To Definition" also opens "Peek Definition" for multiple results #1517

Closed
melak47 opened this issue Feb 2, 2018 · 5 comments
Closed
Labels

Comments

@melak47
Copy link

melak47 commented Feb 2, 2018

When I use "Go To Definition" on a symbol, and Intellisense finds multiple possible matches,
it goes to the definition of the first one -- but also opens up a "Peek Definition" view of the very same definition, along with a list of the other possible matches. (I assume this is by design.)

Most of the time I'm lucky and the first result is the right one, and my reward is an unnecessary "Peek Definition" view I have to close with another F12 press.
Would it be possible to let us configure whether this should open by default or not?

@bobbrow
Copy link
Member

bobbrow commented Feb 2, 2018

I think you'll need to ask the VS Code team if they would consider adding a setting for this. Our extension doesn't have any way to control it (besides maybe discarding all but the first search result which would result in a different level of frustration 😄)

Here's a link to open a new issue for VS Code.

@sean-mcmanus
Copy link
Contributor

Also, after we implement Go to Definition with IntelliSense, only one definition should be returned (if you're using the IntelliSense engine).

@chrisjallen
Copy link

@melak47 Hi did you find any resolve to this, could you point me to any ticket made on vs code? Thanks

@melak47
Copy link
Author

melak47 commented Sep 7, 2018

@chrisjallen #255

@sean-mcmanus
Copy link
Contributor

@chrisjallen @melak47 The vscode issue tracking this is microsoft/vscode#31046 so please upvote that.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants