Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go to Symbol in Workspace doesn't apply search.exclude #5099

Closed
sean-mcmanus opened this issue Mar 11, 2020 · 1 comment
Closed

Go to Symbol in Workspace doesn't apply search.exclude #5099

sean-mcmanus opened this issue Mar 11, 2020 · 1 comment
Labels
bug Feature: Symbol Search fixed Check the Milestone for the release in which the fix is or will be available. Language Service regression A bug that didn't exist in a previous release
Milestone
0.27.0

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Mar 11, 2020 •
edited
Loading

It works with 0.26.3

Looks like search.exclude for symbols doesn't work at all for VS Code: microsoft/vscode#46718
@sean-mcmanus sean-mcmanus added this to the 0.27.0 milestone Mar 11, 2020
@sean-mcmanus sean-mcmanus self-assigned this Mar 11, 2020
@sean-mcmanus sean-mcmanus changed the title Go to Symbol in Workspace doesn't apply search.exclude for multi-root workspaces Go to Symbol in Workspace doesn't apply search.exclude Mar 12, 2020
@sean-mcmanus sean-mcmanus added the regression A bug that didn't exist in a previous release label Mar 12, 2020
@sean-mcmanus sean-mcmanus mentioned this issue Mar 12, 2020
Merged
@sean-mcmanus sean-mcmanus modified the milestones: 0.27.0, 1.0 Mar 13, 2020
@bpasero
Copy link
Member

bpasero commented Mar 16, 2020

fyi see microsoft/vscode#46718 (comment)

@sean-mcmanus sean-mcmanus mentioned this issue Mar 17, 2020
Closed
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Mar 18, 2020
@sean-mcmanus sean-mcmanus removed their assignment Mar 19, 2020
@sean-mcmanus sean-mcmanus modified the milestones: 1.0, 0.27.0 Mar 19, 2020
@bobbrow bobbrow modified the milestones: 0.27.0, 1.0 Mar 27, 2020
@bpasero bpasero mentioned this issue Mar 31, 2020
Closed
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Feature: Symbol Search fixed Check the Milestone for the release in which the fix is or will be available. Language Service regression A bug that didn't exist in a previous release
Projects
None yet
Milestone
0.27.0
Development

No branches or pull requests
3 participants
@bpasero @bobbrow @sean-mcmanus