Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt pre-release extension support #8507

Closed
isidorn opened this issue Dec 9, 2021 · 4 comments
Closed

Adopt pre-release extension support #8507

isidorn opened this issue Dec 9, 2021 · 4 comments
Assignees
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service

Comments

@isidorn
Copy link

isidorn commented Dec 9, 2021

Refs: microsoft/vscode#15756

VS Code now supports pre-release extensions. Docs that should help: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions

I know C++ uses the setting to move users to an insiders version.
This is a bit of a special case since you do not have a separate extension so we do not support migration here. However we suggest that C++ does the following for users that have this settings set:

  • Show a modal dialog or notification to user where she can confirm the transition
  • Once user confirms, execute the command workbench.extensions.installExtension and pass { installPreReleaseVersion: true }
  • Deprecate the setting

Let me know what you think or if I can help somehow.

fyi @bobbrow @sandy081

@bobbrow
Copy link
Member

bobbrow commented Dec 9, 2021

Thanks for opening this @isidorn. It is in our implementation plan for 1.9.0 (which will be the first pre-release), but I think we forgot to create an issue for it so we will use this one.

@Colengms
Copy link
Contributor

@isidorn Could you confirm the format of the call to installExtensions? I have:

vscode.commands.executeCommand("workbench.extensions.installExtension", "ms-vscode.cpptools", { installPreReleaseVersion: true });

Is there a way to detect if this type of installation has already been configured? We could check if we're currently running an Insiders build, but it's possible the user has already switched and not yet reloaded. (Not critical, but thought I would ask.)

@isidorn
Copy link
Author

isidorn commented Dec 15, 2021

@Colengms that looks like a correct code snippet. But @sandy081 should also confirm.
I think there is no way to detect apart from the idea which you already mentioned: check if you are currently running an insiders build.

@sandy081
Copy link
Member

Command format is correct 👍 and also confirms what @isidorn mentioned

@Colengms Colengms modified the milestones: 1.9.0, 1.8.0 Jan 14, 2022
@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label Jan 14, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.8.0, 1.8.0-insiders3 Jan 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

5 participants