Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break Lines with Allman doesn't "work"? #887

Closed
wizardlink opened this issue Jul 16, 2017 · 5 comments
Closed

Break Lines with Allman doesn't "work"? #887

wizardlink opened this issue Jul 16, 2017 · 5 comments
Labels

Comments

@wizardlink
Copy link

So, i usually actually work with Pico indent style, but allman applies the same "technique", and people know it better than Pico... So, when i break a line, on an if statement for example instead of going like this

    if () 
    {
        
    }
    else
    {

    }

It actually goes like this

    if (!client || !message || !args) 
        {
        
        }
        else
            {

            }

Which makes me loose some time with it... I use VSCode on Windows 10, does anyone know how i'd go on fixing this?

@sean-mcmanus
Copy link
Contributor

That doesn't repro for me. Is some other extension causing the formatting? Are you doing some format on type or what?

@sean-mcmanus sean-mcmanus added the more info needed The issue report is not actionable in its current state label Jul 17, 2017
@wizardlink
Copy link
Author

No i literally had a clean and fresh VSC instance, never touched the editor before, i mean i did, but not in this computer, i changed some settings so now i can do it a little better, but i still can't press enter without breaking the line and having some space after it.

@sean-mcmanus
Copy link
Contributor

Does the bug repro without our extension enabled? If so, you should file the bug with VS Code: https://github.com/Microsoft/vscode .

@wizardlink
Copy link
Author

I'm sorry... It was 4AM when i opened this issue, i was looking on google about it, and the first results were other issues on this repository, so i thought it was vscode repo... Sorry for the trouble i caused!

@sean-mcmanus
Copy link
Contributor

That's fine. It highlights a potential problem if our extension were to implement auto-indent on if/for/etc. statements. I think we'd need to add an auto-unindent rule after the { is added on the 2nd line.

@sean-mcmanus sean-mcmanus added external and removed more info needed The issue report is not actionable in its current state labels Jul 17, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants